From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org,
kai.vehmanen@linux.intel.com, seppo.ingalsuo@linux.intel.com,
stable@vger.kernel.org, niranjan.hy@ti.com,
ckeepax@opensource.cirrus.com, sbinding@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: soc-ops: Correct the max value for clamp in soc_mixer_reg_to_ctl()
Date: Wed, 17 Dec 2025 14:20:42 +0200 [thread overview]
Message-ID: <27404fce-b371-4003-b44b-a468572cf76d@linux.intel.com> (raw)
In-Reply-To: <6e97293c-71c1-40a8-8eba-4e2feda1e6ea@sirena.org.uk>
On 17/12/2025 14:16, Mark Brown wrote:
> On Wed, Dec 17, 2025 at 02:06:23PM +0200, Peter Ujfalusi wrote:
>> In 'normal' controls the mc->min is the minimum value the register can
>> have, the mc->max is the maximum (the steps between are max - min).
>
> Have you seen:
>
> https://lore.kernel.org/r/20251216134938.788625-1-sbinding@opensource.cirrus.com
No, I tried to look for possible fixes for this, but have not found it.
I think my one liner is a bit simpler with the same result, but I'll let
people decide which is better (and test on Cirrus side)
--
Péter
next prev parent reply other threads:[~2025-12-17 12:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 12:06 [PATCH] ASoC: soc-ops: Correct the max value for clamp in soc_mixer_reg_to_ctl() Peter Ujfalusi
2025-12-17 12:16 ` Mark Brown
2025-12-17 12:20 ` Péter Ujfalusi [this message]
2025-12-17 12:36 ` Richard Fitzgerald
2025-12-17 12:38 ` Péter Ujfalusi
2025-12-17 12:40 ` Richard Fitzgerald
2025-12-17 12:44 ` Mark Brown
2025-12-17 13:01 ` Péter Ujfalusi
2025-12-17 13:16 ` Richard Fitzgerald
2025-12-17 13:54 ` Péter Ujfalusi
2025-12-17 13:56 ` Mark Brown
2025-12-17 13:59 ` Péter Ujfalusi
2025-12-17 14:00 ` Mark Brown
2025-12-17 14:19 ` Péter Ujfalusi
2025-12-17 14:22 ` Mark Brown
2025-12-17 13:18 ` Mark Brown
2025-12-17 12:17 ` Péter Ujfalusi
2025-12-17 12:47 ` Charles Keepax
2025-12-17 13:13 ` Péter Ujfalusi
2025-12-17 13:42 ` Charles Keepax
2025-12-17 14:31 ` Péter Ujfalusi
2025-12-17 15:00 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27404fce-b371-4003-b44b-a468572cf76d@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=sbinding@opensource.cirrus.com \
--cc=seppo.ingalsuo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox