From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, ebiggers3@gmail.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Kirill Marinushkin <k.marinushkin@gmail.com>,
security@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v6] security/keys: rewrite all of big_key crypto
Date: Tue, 19 Sep 2017 16:38:25 +0100 [thread overview]
Message-ID: <27444.1505835505@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170917115217.15805-1-Jason@zx2c4.com>
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> And, some error paths forgot to zero out sensitive
> material, so this patch changes a kfree into a kzfree.
Can you split that out into a separate preparatory patch?
Also, I recommend limiting the lines in your patch description to 75 chars
lest you get people who run checkpatch on everything pestering you ;-)
David
next prev parent reply other threads:[~2017-09-19 15:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 13:00 [PATCH v4] security/keys: rewrite all of big_key crypto Jason A. Donenfeld
2017-09-16 13:05 ` [PATCH v5] " Jason A. Donenfeld
2017-09-17 6:04 ` Eric Biggers
2017-09-17 11:50 ` Jason A. Donenfeld
2017-09-17 11:52 ` [PATCH v6] " Jason A. Donenfeld
2017-09-19 15:38 ` David Howells [this message]
2017-09-20 14:56 ` Jason A. Donenfeld
2017-09-20 5:30 ` Stephan Mueller
2017-09-20 10:52 ` Jason A. Donenfeld
2017-09-20 13:45 ` Stephan Mueller
2017-09-20 14:01 ` Jason A. Donenfeld
2017-09-20 14:06 ` Stephan Mueller
2017-09-20 14:09 ` Jason A. Donenfeld
2017-09-18 8:49 ` [PATCH v4] " Stephan Mueller
2017-09-18 9:04 ` [kernel-hardening] " Greg KH
2017-09-18 9:12 ` Stephan Mueller
2017-09-18 11:24 ` Jason A. Donenfeld
2017-09-19 13:39 ` Theodore Ts'o
2017-09-19 19:04 ` [kernel-hardening] " Sandy Harris
2017-09-19 19:17 ` Jason A. Donenfeld
2017-09-20 1:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27444.1505835505@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=k.marinushkin@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).