From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: dhowells@redhat.com, Oleg Nesterov <oleg@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>, Kees Cook <kees@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Josh Drake <josh@delphoslabs.com>,
Suraj Sonawane <surajsonawane0215@gmail.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
security@kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] keys: Fix UAF in key_put()
Date: Wed, 19 Mar 2025 18:47:34 +0000 [thread overview]
Message-ID: <2883313.1742410054@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wgqidLD38wYUw-5Y6ztFdAvkX3P+Gv2=K+rpkFBG-bf7g@mail.gmail.com>
Linus Torvalds <torvalds@linuxfoundation.org> wrote:
> We really should have "test_bit_acquire()" and "set_bit_release()".
I considered using test_bit_acquire() but, as you say, there's no
set_bit_release() as yet. I could switch things to initialise the flag to set
on key creation and clear the flag instead.
David
next prev parent reply other threads:[~2025-03-19 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 15:57 [PATCH v2] keys: Fix UAF in key_put() David Howells
2025-03-19 16:30 ` Oleg Nesterov
2025-03-19 18:11 ` Linus Torvalds
2025-03-19 18:47 ` David Howells [this message]
2025-03-20 16:14 ` Jarkko Sakkinen
2025-03-20 16:39 ` David Howells
2025-03-20 17:28 ` Jarkko Sakkinen
2025-03-20 18:46 ` Jarkko Sakkinen
2025-03-20 18:48 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2883313.1742410054@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=josh@delphoslabs.com \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox