From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>, Christian Eggers <ceggers@arri.de>
Cc: stable@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll()
Date: Sun, 2 Aug 2020 17:05:51 +0200 [thread overview]
Message-ID: <28c6add2-311e-5638-e890-53a2248f560a@metafoo.de> (raw)
In-Reply-To: <20200801170234.2953b087@archlinux>
On 8/1/20 6:02 PM, Jonathan Cameron wrote:
> On Mon, 27 Jul 2020 16:57:13 +0200
> Christian Eggers <ceggers@arri.de> wrote:
>
>> iio_trigger_poll() calls generic_handle_irq(). This function expects to
>> be run with local IRQs disabled.
> Was there an error or warning that lead to this patch?
> Or can you point to what call in generic_handle_irq is making the
> assumption that we are breaking?
>
> Given this is using the irq_work framework I'm wondering if this is
> a more general problem?
>
> Basically more info please!
There is this series https://lkml.org/lkml/2020/3/6/433 which causes
generic_handle_irq() to issue an warning if it is called with IRQs on,
for a IRQ controller that can't handle it.
But I'm not convinced this applies to the IIO code, since this is a
purely virtual interrupt and is not interfering with any interrupt
controller hardware.
next prev parent reply other threads:[~2020-08-02 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:57 [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll() Christian Eggers
2020-08-01 16:02 ` Jonathan Cameron
2020-08-02 15:05 ` Lars-Peter Clausen [this message]
2020-08-03 5:16 ` Christian Eggers
2020-08-03 6:37 ` Lars-Peter Clausen
2020-08-03 6:44 ` Christian Eggers
2020-08-03 6:52 ` Lars-Peter Clausen
2020-08-12 11:01 ` Christian Eggers
2020-08-13 7:23 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c6add2-311e-5638-e890-53a2248f560a@metafoo.de \
--to=lars@metafoo.de \
--cc=ceggers@arri.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox