From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA3140DFA7; Tue, 5 May 2026 09:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972233; cv=none; b=P40X1MbtX+n0Nn12unTNRYF4odLSp1uSnBfWXszVaUn9FEU54clHrupTUVmiTx3KljftLGyTJ5gkoDC1zQcpRPkPXjVRvqHoqJNPusUeZ6WbFjDXO97sdnrr6N0vpJ6v61NBmwjdDQK2avrEAVzgpBXlyfDkG4aeMj10FVnhBAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972233; c=relaxed/simple; bh=04Phd2EodbMsYP2y3NGQJMWEWMCcX3OY0kqti3A4TWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ix+rW3EI0QYJREmMeHnGfUWBAviJiwCBYFn7BIrYcw7qpTOXya5JJI4T+MCKRKX59MtVCtO/QE5G6+a0rxU/iu5UbVyqDryz54d3JFt1Lw0exe+TKnxhlDKVOGBS3ZgmsYb6lq3F9bm5AJFpCqspPNOdHH22tmVvREu4flL/46I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ljU9dw3Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ljU9dw3Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C07DC2BCB4; Tue, 5 May 2026 09:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777972232; bh=04Phd2EodbMsYP2y3NGQJMWEWMCcX3OY0kqti3A4TWw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ljU9dw3Yx3q5KEtadg9x0EposMwhmTBg5Zirrb03BwA+vdCB1CEhZNa0HPl/bsy9d 5rMFPb2XIimLsESBPx+KFSBYkBeOV0LnjU6OKfpAgLTefqL+osHn4Z+C49+Csv+a/7 Q6sCCPM3KwvKSYiKgtFBBBXmSpjyBf1B659xFvpSuAr451crgNJTbyqg+gfLzg5M33 6umcRxypX6h56XjRWOR42N34/oyf8IEKZmj2zqcDDkZs/BnRPqh0KAQ58I6/u3PChc 3BWm9YZxGD11a28tO/hE5r9aWCBjxWNzTqJLEbbPBaodo/5ABBkZEBvgO8Wrx2NjNc kbGEWDSgxDyBg== Message-ID: <2bdd7732-e20d-4d67-8f3e-2b9a9a791edf@kernel.org> Date: Tue, 5 May 2026 11:10:29 +0200 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7.0 073/307] ipmi:ssif: Clean up kthread on errors To: Greg Kroah-Hartman , stable@vger.kernel.org Cc: patches@lists.linux.dev, Li Xiao <252270051@hdu.edu.cn>, Corey Minyard References: <20260504135142.814938198@linuxfoundation.org> <20260504135145.562837603@linuxfoundation.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20260504135145.562837603@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04. 05. 26, 15:49, Greg Kroah-Hartman wrote: > 7.0-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Corey Minyard > > commit 75c486cb1bcaa1a3ec3a6438498176a3a4998ae4 upstream. > > If an error occurs after the ssif kthread is created, but before the > main IPMI code starts the ssif interface, the ssif kthread will not > be stopped. > > So make sure the kthread is stopped on an error condition if it is > running. > > Fixes: 259307074bfc ("ipmi: Add SMBus interface driver (SSIF)") > Reported-by: Li Xiao <<252270051@hdu.edu.cn> > Cc: stable@vger.kernel.org > Reviewed-by: Li Xiao <252270051@hdu.edu.cn> > Signed-off-by: Corey Minyard > Signed-off-by: Greg Kroah-Hartman > --- > drivers/char/ipmi/ipmi_ssif.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1268,8 +1268,10 @@ static void shutdown_ssif(void *send_inf > ssif_info->stopping = true; > timer_delete_sync(&ssif_info->watch_timer); > timer_delete_sync(&ssif_info->retry_timer); > - if (ssif_info->thread) > + if (ssif_info->thread) { > kthread_stop(ssif_info->thread); > + ssif_info->thread = NULL; > + } > } > > static void ssif_remove(struct i2c_client *client) > @@ -1916,6 +1918,15 @@ static int ssif_probe(struct i2c_client > > out: > if (rv) { > + /* > + * If ipmi_register_smi() starts the interface, it will > + * call shutdown and that will free the thread and set > + * it to NULL. Otherwise it must be freed here. > + */ > + if (ssif_info->thread) { This 'if' reportedly needs: commit a8aebe93a4938c0ca1941eeaae821738f869be3d Author: Corey Minyard Date: Tue Apr 21 06:50:22 2026 -0500 ipmi:ssif: NULL thread on error > + kthread_stop(ssif_info->thread); > + ssif_info->thread = NULL; > + } > if (addr_info) > addr_info->client = NULL; > > > > -- js suse labs