From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
Michael Halcrow <mhalcrow@google.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key
Date: Tue, 19 Sep 2017 17:09:02 +0100 [thread overview]
Message-ID: <30124.1505837342@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170918183723.114253-1-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> + if (test_bit(KEY_FLAG_NEGATIVE, &key->flags)) {
> + ret = -ENOKEY;
> + goto error2;
> + }
It might be better to do this check in key_validate(). Also, it should
perhaps take the error from key->reject_error.
David
next prev parent reply other threads:[~2017-09-19 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:37 [PATCH] KEYS: prevent KEYCTL_READ on negative key Eric Biggers
2017-09-19 16:09 ` David Howells [this message]
2017-09-21 23:34 ` Eric Biggers
2017-09-25 13:29 ` David Howells
2017-09-25 18:35 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30124.1505837342@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhalcrow@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).