From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Johan Hovold <johan@kernel.org>
Cc: neil.armstrong@linaro.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Abel Vesa <abel.vesa@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge
Date: Fri, 1 Nov 2024 11:49:07 +0800 [thread overview]
Message-ID: <30fefafc-d19a-40cb-bcb1-3c586ba8e67e@linux.dev> (raw)
In-Reply-To: <ZyOvAqnuxbNnGWli@hovoldconsulting.com>
On 2024/11/1 00:23, Johan Hovold wrote:
> On Thu, Oct 31, 2024 at 11:06:38PM +0800, Sui Jingfeng wrote:
>
>> But I think Johan do need more times to understand what exactly
>> the real problem is. We do need times to investigate new method.
> No, I know perfectly well what the (immediate) problem is here (I was
> the one adding support for the of_node_reused flag some years back).
>
> I just wanted to make sure that the commit message was correct and
> complete before merging (and also to figure out whether this particular
> patch needed to be backported).
Well under such a design, having the child device sharing the 'OF' device
node with it parent device means that one parent device can *only*
create one AUX bridge child device.
Since If you create two or more child AUX bridge, *all* of them will
call devm_drm_of_get_bridge(&auxdev->dev, auxdev->dev.of_node, 0, 0),
then we will *contend* the same next bridge resource.
Because of the 'auxdev->dev.of_node' is same for all its instance.
While other display bridges seems don't has such limitations.
> Johan
--
Best regards,
Sui
next prev parent reply other threads:[~2024-11-01 3:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 12:49 [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge Abel Vesa
2024-10-18 15:43 ` Dmitry Baryshkov
2024-10-30 16:45 ` Sui Jingfeng
2024-10-30 19:39 ` Laurent Pinchart
2024-10-31 12:29 ` Neil Armstrong
2024-10-21 7:12 ` Neil Armstrong
2024-10-21 7:23 ` Johan Hovold
2024-10-31 14:05 ` Johan Hovold
2024-10-31 16:13 ` Abel Vesa
2024-10-31 16:33 ` Johan Hovold
2024-11-01 9:49 ` Abel Vesa
2024-10-31 15:48 ` Dmitry Baryshkov
2024-10-31 16:26 ` Johan Hovold
2024-10-21 13:08 ` Neil Armstrong
2024-10-30 14:49 ` Sui Jingfeng
2024-10-31 12:31 ` Neil Armstrong
2024-10-31 14:02 ` Johan Hovold
2024-10-31 15:31 ` Sui Jingfeng
2024-10-31 15:06 ` Sui Jingfeng
2024-10-31 16:23 ` Johan Hovold
2024-11-01 3:49 ` Sui Jingfeng [this message]
2024-11-01 7:27 ` Johan Hovold
2024-11-01 9:20 ` Laurent Pinchart
2024-11-01 10:27 ` Dmitry Baryshkov
2024-11-01 14:43 ` Laurent Pinchart
2024-11-01 6:15 ` Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fefafc-d19a-40cb-bcb1-3c586ba8e67e@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=abel.vesa@linaro.org \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=johan@kernel.org \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox