From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>, Michael Lyle <mlyle@lyle.org>
Cc: linux-bcache <linux-bcache@vger.kernel.org>,
linux-block@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 14/17] bcache: back to cache all readahead I/Os
Date: Thu, 23 Jan 2020 11:31:47 -0700 [thread overview]
Message-ID: <31f7f6b4-98ea-3cf6-44cc-a9ba67484eb0@kernel.dk> (raw)
In-Reply-To: <efdfdd2b-b22e-42d1-c642-6c398db6864c@suse.de>
On 1/23/20 10:27 AM, Coly Li wrote:
> On 2020/1/24 1:19 上午, Michael Lyle wrote:
>> Hi Coly and Jens--
>>
>> One concern I have with this is that it's going to wear out
>> limited-lifetime SSDs a -lot- faster. Was any thought given to making
>> this a tunable instead of just changing the behavior? Even if we have
>> an anecdote or two that it seems to have increased performance for
>> some workloads, I don't expect it will have increased performance in
>> general and it may even be costly for some workloads (it all comes
>> down to what is more useful in the cache-- somewhat-recently readahead
>> data, or the data that it is displacing).
>
> Hi Mike,
>
> Copied. This is good suggestion, I will do it after I back from Lunar
> New Year vacation, and submit it with other tested patches in following
> v5.6-rc versions.
Do you want me to just drop this patch for now from the series?
--
Jens Axboe
next prev parent reply other threads:[~2020-01-23 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200123170142.98974-1-colyli@suse.de>
2020-01-23 17:01 ` [PATCH 14/17] bcache: back to cache all readahead I/Os colyli
2020-01-23 17:19 ` Michael Lyle
2020-01-23 17:27 ` Coly Li
2020-01-23 18:31 ` Jens Axboe [this message]
2020-01-24 0:49 ` Coly Li
2020-01-24 1:14 ` Jens Axboe
2020-01-24 16:48 ` Michael Lyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f7f6b4-98ea-3cf6-44cc-a9ba67484eb0@kernel.dk \
--to=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox