From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org
Cc: Steam Lin <stlin2@winbond.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
Sridharan S N <quic_sridsn@quicinc.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/4] mtd: spi-nand: winbond: Fix 512GW, 01GW, 01JW and 02JW ECC information
Date: Wed, 9 Oct 2024 15:33:11 +0200 [thread overview]
Message-ID: <3345c66e-6f18-4bc7-8e52-4af7de6ff401@kontron.de> (raw)
In-Reply-To: <20241009125002.191109-3-miquel.raynal@bootlin.com>
On 09.10.24 2:50 PM, Miquel Raynal wrote:
> These four chips:
> * W25N512GW
> * W25N01GW
> * W25N01JW
> * W25N02JW
> all require a single bit of ECC strength and thus feature an on-die
> Hamming-like ECC engine. There is no point in filling a ->get_status()
> callback for them because the main ECC status bytes are located in
> standard places, and retrieving the number of bitflips in case of
> corrected chunk is both useless and unsupported (if there are bitflips,
> then there is 1 at most, so no need to query the chip for that).
>
> Without this change, a kernel warning triggers every time a bit flips.
>
> Fixes: 6a804fb72de5 ("mtd: spinand: winbond: add support for serial NAND flash")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
I had a quick look at the datasheets and this seems correct to me.
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
next prev parent reply other threads:[~2024-10-09 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241009125002.191109-1-miquel.raynal@bootlin.com>
2024-10-09 12:49 ` [PATCH 1/4] mtd: spi-nand: winbond: Fix 512GW and 02JW OOB layout Miquel Raynal
2024-10-09 13:16 ` Frieder Schrempf
2024-10-21 10:02 ` Miquel Raynal
2024-10-09 12:50 ` [PATCH 2/4] mtd: spi-nand: winbond: Fix 512GW, 01GW, 01JW and 02JW ECC information Miquel Raynal
2024-10-09 13:33 ` Frieder Schrempf [this message]
2024-10-09 14:47 ` Miquel Raynal
2024-10-21 10:02 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3345c66e-6f18-4bc7-8e52-4af7de6ff401@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=quic_sridsn@quicinc.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=stlin2@winbond.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox