Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace

Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace

[Jérôme Pouiller]

[add stable@vger.kernel.org to the recipients]

On Tuesday 17 May 2022 09:30:24 CEST Christian König wrote:
> Am 17.05.22 um 09:27 schrieb Jerome Pouiller:
> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >
> > The typedefs u32 and u64 are not available in userspace. Thus user get
> > an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B:
> >
> >      $ gcc -Wall   -c -MMD -c -o ioctls_list.o ioctls_list.c
> >      In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1,
> >                       from /usr/include/linux/ioctl.h:5,
> >                       from /usr/include/asm-generic/ioctls.h:5,
> >                       from ioctls_list.c:11:
> >      ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function)
> >        463 |     { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h
> >            |                             ^~~~~~~~~~~~~~~~~~
> >      ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function)
> >        464 |     { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h
> >            |                             ^~~~~~~~~~~~~~~~~~
> >
> > The issue was initially reported here[1].
> >
> > [1]: https://urldefense.com/v3/__https://nam11.safelinks.protection.outlook.com/?url=https*3A*2F*2Fgithub.com*2Fjerome-pouiller*2Fioctl*2Fpull*2F14&amp;data=05*7C01*7Cchristian.koenig*40amd.com*7C4b665e3c2222463014ec08da37d6b3f4*7C3dd8961fe4884e608e11a82d994e183d*7C0*7C0*7C637883692533547283*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C3000*7C*7C*7C&amp;sdata=prj*2BSOuf*2B1IWK1XKGD381LhDuL9qOoj7lYy8xMoV*2B6o*3D&amp;reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSU!!N30Cs7Jr!Vp-6M6kuBq4uqEHaYTbkJbN3BTkd85DAeGS7xNYLPbNMp00kBlbD0iQPjJdQ5OVCFeCp_XVrsYIhxvLlpLQDmRhK5QXhQA$
> >
> > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> 
> Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
> 
> CC: stable?

Done

> Fixes: ?

Fixes: a5bff92eaac4 ("dma-buf: Fix SET_NAME ioctl uapi")

-- 
Jérôme Pouiller

Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace

[Greg KH]

On Tue, May 17, 2022 at 10:32:15AM +0200, Jérôme Pouiller wrote:
> [add stable@vger.kernel.org to the recipients]
> 
> On Tuesday 17 May 2022 09:30:24 CEST Christian König wrote:
> > Am 17.05.22 um 09:27 schrieb Jerome Pouiller:
> > > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> > >
> > > The typedefs u32 and u64 are not available in userspace. Thus user get
> > > an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B:
> > >
> > >      $ gcc -Wall   -c -MMD -c -o ioctls_list.o ioctls_list.c
> > >      In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1,
> > >                       from /usr/include/linux/ioctl.h:5,
> > >                       from /usr/include/asm-generic/ioctls.h:5,
> > >                       from ioctls_list.c:11:
> > >      ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function)
> > >        463 |     { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h
> > >            |                             ^~~~~~~~~~~~~~~~~~
> > >      ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function)
> > >        464 |     { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h
> > >            |                             ^~~~~~~~~~~~~~~~~~
> > >
> > > The issue was initially reported here[1].
> > >
> > > [1]: https://urldefense.com/v3/__https://nam11.safelinks.protection.outlook.com/?url=https*3A*2F*2Fgithub.com*2Fjerome-pouiller*2Fioctl*2Fpull*2F14&amp;data=05*7C01*7Cchristian.koenig*40amd.com*7C4b665e3c2222463014ec08da37d6b3f4*7C3dd8961fe4884e608e11a82d994e183d*7C0*7C0*7C637883692533547283*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C3000*7C*7C*7C&amp;sdata=prj*2BSOuf*2B1IWK1XKGD381LhDuL9qOoj7lYy8xMoV*2B6o*3D&amp;reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSUlJSUlJSU!!N30Cs7Jr!Vp-6M6kuBq4uqEHaYTbkJbN3BTkd85DAeGS7xNYLPbNMp00kBlbD0iQPjJdQ5OVCFeCp_XVrsYIhxvLlpLQDmRhK5QXhQA$
> > >
> > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> > 
> > Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
> > 
> > CC: stable?
> 
> Done

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>