From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pg0-f51.google.com ([74.125.83.51]:39920 "EHLO
        mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753942AbeDZLj2 (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 26 Apr 2018 07:39:28 -0400
Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M
To: =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>,
        Johan Hovold <johan@kernel.org>
Cc: =?UTF-8?B?U1ogTGluICjmnpfkuIrmmbop?= <sz.lin@moxa.com>,
        stable <stable@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dan Williams <dcbw@redhat.com>
References: <20180426062831.320-1-sz.lin@moxa.com>
 <20180426070927.GT4615@localhost>
 <72c63853-aa2d-e74c-1112-36d54ef52a85@gmail.com>
 <20180426081403.GA335@localhost> <87r2n25i6i.fsf@miraculix.mork.no>
From: Lars Melin <larsm17@gmail.com>
Message-ID: <3895ed90-bbb9-e7ce-34c0-a1654646cf83@gmail.com>
Date: Thu, 26 Apr 2018 18:39:22 +0700
MIME-Version: 1.0
In-Reply-To: <87r2n25i6i.fsf@miraculix.mork.no>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 4/26/2018 18:19, Bjørn Mork wrote:
> Anyway, Qualcomm based designs are definitely handled by both drivers.
> Using qcserial only makes sense if the interface layout matches one of
> the defined shared schemes, which currently are:
> 
> 	QCSERIAL_G2K = 0,	/* Gobi 2000 */
> 	QCSERIAL_G1K = 1,	/* Gobi 1000 */
> 	QCSERIAL_SWI = 2,	/* Sierra Wireless */
> 	QCSERIAL_HWI = 3,	/* Huawei */

It seems to me that this Quectel device matches the interface layout for 
Gobi1K:

		 * Gobi 1K USB layout:
		 * 0: DM/DIAG (use libqcdm from ModemManager for communication)
		 * 1: serial port (doesn't respond)
		 * 2: AT-capable modem port
		 * 3: QMI/net
		 */

/Lars