From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
kernel@oss.qualcomm.com, prasad.kumpatla@oss.qualcomm.com,
ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
Date: Wed, 10 Sep 2025 11:45:15 +0200 [thread overview]
Message-ID: <3a884a4e-4e2a-47ce-b128-ae987bb6d3dd@kernel.org> (raw)
In-Reply-To: <20250910044512.1369640-1-mohammad.rafi.shaik@oss.qualcomm.com>
On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",
> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
> This patch series depends on patch series:
> https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index f3c5d363921e..7187c1760ef5 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
> };
>
> sound {
> - compatible = "qcom,qcs8275-sndcard";
> + compatible = "qcom,qcs8300-sndcard";
The other patch claims that changing binding would be ABI break, so
obviously here is actual impact on users.
Also, the other patch explains that it is the same hardware, so we are
back at previous discussions (sc8380xp, sa8775p etc): we do not rename
compatibles just because your prefer something else now.
That's a NAK.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-09-10 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 4:45 [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC Mohammad Rafi Shaik
2025-09-10 4:47 ` kernel test robot
2025-09-10 7:24 ` Krzysztof Kozlowski
2025-09-10 9:45 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a884a4e-4e2a-47ce-b128-ae987bb6d3dd@kernel.org \
--to=krzk@kernel.org \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox