From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E6AC3F2CE for ; Wed, 4 Mar 2020 19:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57DED20828 for ; Wed, 4 Mar 2020 19:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgCDTbB (ORCPT ); Wed, 4 Mar 2020 14:31:01 -0500 Received: from mga01.intel.com ([192.55.52.88]:42307 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727137AbgCDTbB (ORCPT ); Wed, 4 Mar 2020 14:31:01 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 11:31:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,514,1574150400"; d="scan'208";a="229433110" Received: from smhiray-mobl1.amr.corp.intel.com (HELO [10.252.140.1]) ([10.252.140.1]) by orsmga007.jf.intel.com with ESMTP; 04 Mar 2020 11:31:00 -0800 Subject: Re: 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components" To: Mark Brown Cc: Sasha Levin , Takashi Iwai , ALSA development , stable@vger.kernel.org References: <147efa37-eb57-7f17-b9eb-84a9fe5ad475@perex.cz> <20200304154450.GB5646@sirena.org.uk> <20200304160916.GC5646@sirena.org.uk> <44cf4ff8-120f-79fd-8801-47807b03f912@linux.intel.com> <20200304181113.GE5646@sirena.org.uk> <669e6e57-3a84-7cf5-398f-eefdd333fadb@linux.intel.com> <20200304190620.GF5646@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <3b00df9a-6b53-def7-4304-d9829de749c6@linux.intel.com> Date: Wed, 4 Mar 2020 13:30:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200304190620.GF5646@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 3/4/20 1:06 PM, Mark Brown wrote: > On Wed, Mar 04, 2020 at 12:50:54PM -0600, Pierre-Louis Bossart wrote: > >>> This thread is the first suggestion I've seen that this is any kind of >>> bug fix. There's no Fixes tag and the patch description itself sounds >>> like it's adding a new feature to enable new functionality in userspace >>> (autodetection by UCM) and it was posted as part of a series "ASoC: SOF: >>> initial cleanup for DT and multi-client support" which again doesn't >>> give any indication that this might be supposed to be a bug fix. > >> the initial patch came from Jaroslav on 11/26, not from me. Quoting your own >> words: > >> "Since Pierre seems happy with it even if he didn't ack it explicitly >> I'll guess I'll apply it. If git can figure out applying it after the >> merge window and it doesn't get negative reviews there's no need to >> resend. If it can't and it doesn't turn up in a bigger series before >> then I'll let you know. >> " > > Right, that's me saying I'll apply something that looks like normal > development work after the merge window as with other normal development > work (even Jaroslav's initial version was sent after the merge window > opened), not that I'll apply it as a fix. There's no hint in any of > that thread or in your resend that this was anything other than a new > feature, and indeed you were talking about wanting to integrate it with > a series that you didn't want to see in v5.5. Jaroslav mentioned not > wanting to delay if it'd cause him to miss the merge window but didn't > seem to complain when I said he'd missed it with his initial posting. ok, I misunderstood your reply then. I thought you would provide it as an update for v5.5, thanks for the clarification > Anyway, is my understanding correct that this is fixing a regression > caused by switching the default to SOF? This is fixing a regression on platforms that have digital microphones, where SOF is automatically selected by default. For platforms without DMICs, the legacy driver is still used and this patch has no effect.