From: Trond Myklebust <trondmy@hammerspace.com>
To: "chenxiaosongemail@foxmail.com" <chenxiaosongemail@foxmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"chenxiaosong@kylinos.cn" <chenxiaosong@kylinos.cn>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"huangjinhui@kylinos.cn" <huangjinhui@kylinos.cn>,
"liuzhengyuan@kylinos.cn" <liuzhengyuan@kylinos.cn>,
"liuyun01@kylinos.cn" <liuyun01@kylinos.cn>,
"huhai@kylinos.cn" <huhai@kylinos.cn>,
"sashal@kernel.org" <sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Anna.Schumaker@netapp.com" <Anna.Schumaker@netapp.com>
Subject: Re: Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt file writeout due to fatal errors"
Date: Mon, 30 Oct 2023 14:56:40 +0000 [thread overview]
Message-ID: <3b8caab5918d06f436a889bc1dba09686fc0fad5.camel@hammerspace.com> (raw)
In-Reply-To: <tencent_21E20176E2E5AB7C33CB5E67F10D02763508@qq.com>
On Mon, 2023-10-30 at 17:04 +0800, ChenXiaoSong wrote:
> [You don't often get email from chenxiaosongemail@foxmail.com. Learn
> why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> On 2023/10/30 16:58, Greg KH wrote:
> > If you just revert that one patch, is the issue resolved? And what
> > about other stable releases that have that change in it?
> >
> > If this does need to be reverted, please submit a patch that does
> > so and
> > we can review it that way.
> >
> > thanks,
> >
> > greg k-h
>
>
> In my opinion, this patch is not for fixing a bug, but is part of a
> refactoring patchset. The 'Fixes:' tag should not be added.
>
>
A refactoring is by definition a change that does not affect code
behaviour. It is obvious that this was never intended to be such a
patch.
The reason that the bug is occurring in 4.19.x, and not in the latest
kernels, is because the former is missing another bugfix (one which
actually is missing a "Fixes:" tag).
Can you therefore please check if applying commit 22876f540bdf ("NFS:
Don't call generic_error_remove_page() while holding locks") fixes the
issue.
Note that the latter patch is needed in any case in order to fix a read
deadlock (as indicated on the label).
Thanks,
Trond
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2023-10-30 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 8:39 Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt file writeout due to fatal errors" ChenXiaoSong
2023-10-30 8:43 ` Greg KH
2023-10-30 8:54 ` ChenXiaoSong
2023-10-30 8:58 ` Greg KH
2023-10-30 9:04 ` ChenXiaoSong
2023-10-30 9:19 ` Greg KH
2023-10-30 14:56 ` Trond Myklebust [this message]
2023-11-17 3:28 ` ChenXiaoSong
2023-11-17 4:09 ` ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b8caab5918d06f436a889bc1dba09686fc0fad5.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=Anna.Schumaker@netapp.com \
--cc=chenxiaosong@kylinos.cn \
--cc=chenxiaosongemail@foxmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=huangjinhui@kylinos.cn \
--cc=huhai@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=liuzhengyuan@kylinos.cn \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox