From: "yaoaili [么爱利]" <yaoaili@kingsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>,
"yaoaili126@163.com" <yaoaili126@163.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] ACPI, APEI, Fix error return value in apei_map_generic_address()
Date: Tue, 10 Nov 2020 09:42:21 +0000 [thread overview]
Message-ID: <3fcd32bf58204b26915474fab652e6bb@kingsoft.com> (raw)
In-Reply-To: <X6pbGq24Gta7Go0t@kroah.com>
Sorry for confusing. I am really new to kernel community!
I should just add the tag 'Cc: <stable@vger.kernel.org>' , not really cc to stable@vger.kernel.org
sorry for this!
Best Regards!
Aili Yao
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, November 10, 2020 5:19 PM
> To: yaoaili126@163.com
> Cc: yaoaili <yaoaili@kingsoft.com>; stable@vger.kernel.org
> Subject: Re: [PATCH] ACPI, APEI, Fix error return value in
> apei_map_generic_address()
>
> On Tue, Nov 10, 2020 at 12:29:42AM -0800, yaoaili126@163.com wrote:
> > From: Aili Yao <yaoaili@kingsoft.com>
> >
> > >From commit 6915564dc5a8 ("ACPI: OSL: Change the type of
> > acpi_os_map_generic_address() return value"),
> > acpi_os_map_generic_address() will return logical address or NULL for
> > error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return
> > 0, as it's a normal case, but now it will return -ENXIO. so check it
> > out for such case to avoid einj module initialization fail.
> >
> > Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of
> > acpi_os_map_generic_address() return value")
> > Cc: <stable@vger.kernel.org>
> > Reviewed-by: James Morse <james.morse@arm.com>
> > Tested-by: Tony Luck <tony.luck@intel.com>
> > Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
> > ---
> > drivers/acpi/apei/apei-base.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> I'm confused as to what you are asking us to do with this patch? Have you
> read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-11-10 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 8:29 [PATCH] ACPI, APEI, Fix error return value in apei_map_generic_address() yaoaili126
2020-11-10 9:19 ` Greg KH
2020-11-10 9:42 ` yaoaili [么爱利] [this message]
2020-11-10 9:49 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-11-10 8:33 yaoaili126
2020-11-16 18:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fcd32bf58204b26915474fab652e6bb@kingsoft.com \
--to=yaoaili@kingsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=yaoaili126@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox