From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.eperm.de ([89.247.134.16]:60022 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbdFGFOX (ORCPT ); Wed, 7 Jun 2017 01:14:23 -0400 From: Stephan =?ISO-8859-1?Q?M=FCller?= To: "Jason A. Donenfeld" Cc: keyrings@vger.kernel.org, David Howells , Eric Biggers , Herbert Xu , Kirill Marinushkin , security@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] security/keys: rewrite all of big_key crypto Date: Wed, 07 Jun 2017 07:14:20 +0200 Message-ID: <4079216.Z1x2SUeU2i@tauon.chronox.de> In-Reply-To: <20170606173900.29279-1-Jason@zx2c4.com> References: <20170606173900.29279-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: stable-owner@vger.kernel.org List-ID: Am Dienstag, 6. Juni 2017, 19:39:00 CEST schrieb Jason A. Donenfeld: Hi Jason, > This started out as just replacing the use of crypto/rng with I have some concerns on this part. The use of crypto/rng is to help all users, including those who like FIPS and Co. The crypto/rng code per default uses the DRBG which is mandatory for several people. I wish it would not be needed such that the get_random_bytes provides the possibility to use a DRBG ... . As the DRBG has considerations around early boot entropy, I would think that the entropy discussion is not applicable here. Thanks Stephan