From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([203.11.71.1]:37777 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392416AbeLVRBE (ORCPT ); Sat, 22 Dec 2018 12:01:04 -0500 In-Reply-To: <154445509294.867383.14905585855902294361.stgit@bahia.lan> To: Greg Kurz , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Christophe Lombard , Vaibhav Jain , stable@vger.kernel.org, Frederic Barrat , Andrew Donnellan Subject: Re: ocxl: Clarify error path in setup_xsl_irq() Message-Id: <43MLSc5tbHz9sNM@ozlabs.org> Date: Sat, 22 Dec 2018 20:54:40 +1100 (AEDT) Sender: stable-owner@vger.kernel.org List-ID: On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote: > Implementing rollback with goto and labels is a common practice that > leads to prettier and more maintainable code. FWIW, this design pattern > is already being used in alloc_link() a few lines below in this file. > > Do the same in setup_xsl_irq(). > > Signed-off-by: Greg Kurz > Acked-by: Frederic Barrat > Acked-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/759bc01586535700fbb1aaf40dd727 cheers