From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD07A334C27 for ; Tue, 28 Apr 2026 09:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777368123; cv=none; b=B3etc9vWcX6GEYrFMJzT/06boqImU+x+YtF8+KfBLMM5CtM+cCASA2k4djAkHxw9nyk+CifYHb+cs0Uq/lzei6zKm7FIIeDdW8oFNNMTPQCrw8ujCjNCePybtWOGztqQTI+3YE5/eh/K59N+5vgEr+4pjsAx8YETt6VvY3+kH3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777368123; c=relaxed/simple; bh=xwdhCIsDzsUndt0fN1DFv5y4ol6vuXneCPXfkJ3rv3I=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=RCyrI9ed+ky9FbmrhXEbUr52HtuKKz0sw64nxptF0sFzMlB1Qa29tsL2oc7DXBPvF+acEZEh/8AUXlXTsgrXsOyE6xMLusRZgsVvFKXvpcdxmrsV+GaD6xD0BPS6lglPsLMIXfyKNUHVMmpZ8DkU7O5vuJO3J6n9Gh/b9MpHaTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dS30g3px; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dS30g3px" Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777368109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwdhCIsDzsUndt0fN1DFv5y4ol6vuXneCPXfkJ3rv3I=; b=dS30g3pxAQECsLqXNpTYtDUDVrkf1D942/Jb0Vg+uqVnWtfcZuAOdOetuJNWaRlhiJjxeT yPn5bmMw9t8ruJcZInnv10V6Xuyxxc/Ga1bqL/WvpQFwaQHu0K3/FWqLj9xeQTwQ+kfrzz 67U5Ezas6Tq69R+VfxEi2iqI1qoZ3gY= Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\)) Subject: Re: [PATCH v2 3/3] drivers/base/memory: fix locking for poison accounting lookup X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 28 Apr 2026 17:21:00 +0800 Cc: Muchun Song , David Hildenbrand , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Andrew Morton , Vishal Verma , Ying Huang , Dan Williams , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <4542EE05-E18A-486F-ADF7-E72F71D9A327@linux.dev> References: <20260428085219.1316047-1-songmuchun@bytedance.com> <20260428085219.1316047-4-songmuchun@bytedance.com> To: Oscar Salvador X-Migadu-Flow: FLOW_OUT > On Apr 28, 2026, at 17:17, Oscar Salvador wrote: >=20 > On Tue, Apr 28, 2026 at 04:52:19PM +0800, Muchun Song wrote: >> memblk_nr_poison_inc() and memblk_nr_poison_sub() call >> find_memory_block_by_id(), which requires device_hotplug_lock to >> serialize the xarray lookup against memory block removal. >>=20 >> Take device_hotplug_lock around the lookup and nr_hwpoison update so >> the memory block cannot disappear between xa_load() and get_device(). >>=20 >> Fixes: 5033091de814 ("mm/hwpoison: introduce per-memory_block = hwpoison counter") >> Cc: stable@vger.kernel.org >> Signed-off-by: Muchun Song >=20 > It might have made sense to join both patches? Anyway: Either way works for me. I=E2=80=99ve been following the 'one thing per patch' principle. If I still need to update v3, I can merge them; otherwise, I=E2=80=99d prefer to keep it as is. I'm a little lazy. :) >=20 > Acked-by: Oscar Salvador Thanks. >=20 >=20 > --=20 > Oscar Salvador > SUSE Labs