public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
	"Berg, Johannes" <johannes.berg@intel.com>,
	"Gorgenyi, Frank" <frankgor@google.com>
Subject: Re: [PATCH 6.6] wifi: iwlwifi: support BIOS override for 5G9 in CA also in LARI version 8
Date: Thu, 20 Mar 2025 13:29:45 +0000	[thread overview]
Message-ID: <45ccdb188570eb17ae480d2e29aedfc0d284902e.camel@intel.com> (raw)
In-Reply-To: <20250320132220.33536-1-emmanuel.grumbach@intel.com>

Hello stable kernel maintainers,

On Thu, 2025-03-20 at 15:22 +0200, Emmanuel Grumbach wrote:
> From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> 
> commit b1e8102a4048003097c7054cbc00bbda91a5ced7 upstream
> 
> Commit 6b3e87cc0ca5 ("iwlwifi: Add support for LARI_CONFIG_CHANGE_CMD
> cmd v9")
> added a few bits to
> iwl_lari_config_change_cmd::oem_unii4_allow_bitmap
> if the FW has LARI version >= 9.
> But we also need to send those bits for version 8 if the FW is
> capable
> of this feature (indicated with capability bits)
> Add the FW capability bit, and set the additional bits in the cmd
> when
> the version is 8 and the FW capability bit is set.
> 
> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Reviewed-by: Johannes Berg <johannes.berg@intel.com>
> Link:
> https://patch.msgid.link/20241226174257.dc5836f84514.I1e38f94465a36731034c94b9811de10cb6ee5921@changeid
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/fw/file.h |  4 ++-
>  drivers/net/wireless/intel/iwlwifi/mvm/fw.c  | 37
> ++++++++++++++++++--
>  2 files changed, 38 insertions(+), 3 deletions(-)

I didn't want to alter the commit log of this patch, but this patch has
a bigger impact that just enabling a feature in the firmware. It checks
that the firmware actually supports that feature and this fixes crashes
that were reported on certain device / platform combinations that made
wifi unusable.

  reply	other threads:[~2025-03-20 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 13:22 [PATCH 6.6] wifi: iwlwifi: support BIOS override for 5G9 in CA also in LARI version 8 Emmanuel Grumbach
2025-03-20 13:29 ` Grumbach, Emmanuel [this message]
2025-03-20 16:03 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ccdb188570eb17ae480d2e29aedfc0d284902e.camel@intel.com \
    --to=emmanuel.grumbach@intel.com \
    --cc=frankgor@google.com \
    --cc=johannes.berg@intel.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox