Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

[Dragan Simic <dsimic@manjaro.org>]

Hello all,

On 2024-08-01 17:22, Sebastian Reichel wrote:
> On Thu, Aug 01, 2024 at 02:18:23PM GMT, Lee Jones wrote:
>> > +	/*
>> > +	 * Currently the Rockchip SPI driver always sleeps when doing SPI
>> > +	 * transfers. This is not allowed in the SYS_OFF_MODE_POWER_OFF
>> > +	 * handler, so we are using the prepare handler as a workaround.
>> > +	 * This should be removed once the Rockchip SPI driver has been
>> > +	 * adapted.
>> > +	 */
>> 
>> So why not just adapt the SPI driver now?
> 
> This patch is simple and thus can easily be backported, so that the
> Acer Chromebook shutdown is fixed in the stable kernels. SPI based
> rkxx has been using SYS_OFF_MODE_POWER_OFF_PREPARE from the start,
> so it's not a regression.
> 
> As far as I could see the SPI framework does not have something
> comparable to the I2C .xfer_atomic handler. So fixing up the
> Rockchip SPI driver probably involves creating some SPI core
> helpers. I'm not yet sure about the best way to deal with this.
> But I guess it will be better not having to backport all of the
> requires changes to stable.
> 
> In any case I think the next step in this direction is discussing
> how to handle this in general for SPI.

I agree about accepting this (hot)fix first, and improving the SPI
drivers later.  Having this fixed now provides clear benefits.

Also, please feel free to include:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

>> What's the bet that if accepted, this hack is still here in 5 years 
>> time?
> 
> Even if I don't work on this now, I would expect somebody to have
> issues with broken shutdown on RK3588 boards before 5 years are
> over :)