From: Oliver Neukum <oneukum@suse.de>
To: Josua Dietze <digidietze@draisberghof.de>
Cc: "Bjørn Mork" <bjorn@mork.no>,
"Matthew Dharm" <mdharm-usb@one-eyed-alien.net>,
"Ben Hutchings" <ben@decadent.org.uk>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Fangxiaozhi (Franko)" <fangxiaozhi@huawei.com>,
zihan@huawei.com, Lin.Lei@huawei.com,
"Greg KH" <gregkh@linuxfoundation.org>,
"Yili (Neil)" <neil.yi@huawei.com>,
"Wangyuhua (Roger, Credit)" <wangyuhua@huawei.com>,
Huqiao <huqiao36@huawei.com>, "Felipe Balbi" <balbi@ti.com>,
"Sebastian Andrzej Siewior" <sebastian@breakpoint.cc>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: storage: fix Huawei mode switching regression
Date: Tue, 05 Mar 2013 09:32:32 +0100 [thread overview]
Message-ID: <4661149.JOvxeICSJy@linux-5eaq.site> (raw)
In-Reply-To: <5135201F.4030200@draisberghof.de>
On Monday 04 March 2013 23:28:47 Josua Dietze wrote:
> > I guess the real problem will be verifying that all of the entries can
> > go away. This type of hardware tends to get old very fast, but there is
> > always someone having a really ancient device.
>
> I will check this and add any missing USB IDs to usb_modeswitch, but I can't shake the feeling that not all Huawei entries in "unusual_devs.h" did actually materialize as devices ...
>
> Anyway, as Bj�rn said, putting that initialization into the storage driver takes away quite some possibilities to handle these modems in a flexible way.
But it adds the ability to handle loss of power in the suspend case
cleanly. As long as the switch only makes additional devices appear,
doing it in kernel space is the nicer approach.
Regards
Oliver
next prev parent reply other threads:[~2013-03-05 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87obezs888.fsf@nemi.mork.no>
2013-03-04 13:19 ` [PATCH] USB: storage: fix Huawei mode switching regression Bjørn Mork
2013-03-04 14:29 ` Ben Hutchings
2013-03-04 16:47 ` Bjørn Mork
2013-03-04 16:59 ` Matthew Dharm
2013-03-04 19:22 ` Bjørn Mork
2013-03-04 22:28 ` Josua Dietze
2013-03-05 8:32 ` Oliver Neukum [this message]
2013-03-05 11:35 ` Bjørn Mork
2013-03-05 2:15 ` Fangxiaozhi (Franko)
2013-03-05 10:07 ` Bjørn Mork
2013-03-05 11:52 ` Oliver Neukum
2013-03-05 14:08 ` Bjørn Mork
2013-03-06 1:34 ` 答复: " Linlei (Lei Lin)
2013-03-06 1:44 ` Greg KH
2013-03-06 15:45 ` Dan Williams
2013-03-07 2:54 ` Fangxiaozhi (Franko)
2013-03-07 3:18 ` Greg KH
2013-03-07 12:19 ` Bjørn Mork
2013-03-07 14:11 ` Josua Dietze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4661149.JOvxeICSJy@linux-5eaq.site \
--to=oneukum@suse.de \
--cc=Lin.Lei@huawei.com \
--cc=balbi@ti.com \
--cc=ben@decadent.org.uk \
--cc=bjorn@mork.no \
--cc=digidietze@draisberghof.de \
--cc=fangxiaozhi@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huqiao36@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=neil.yi@huawei.com \
--cc=sebastian@breakpoint.cc \
--cc=stable@vger.kernel.org \
--cc=wangyuhua@huawei.com \
--cc=zihan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).