From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org
Cc: tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
gregkh@linuxfoundation.org,
Bard liao <yung-chuan.liao@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>,
Philippe Ombredanne <pombredanne@nexb.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Subject: Re: [RFC PATCH 2/2] soundwire: fix initializing sysfs for same devices on different buses
Date: Thu, 23 Nov 2023 11:58:19 +0100 [thread overview]
Message-ID: <479c16ce-da90-4571-bd08-b592d63f06cf@linaro.org> (raw)
In-Reply-To: <20231017160933.12624-3-pierre-louis.bossart@linux.intel.com>
On 17/10/2023 18:09, Pierre-Louis Bossart wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> If same devices with same device IDs are present on different soundwire
> buses, the probe fails due to conflicting device names and sysfs
> entries:
>
> sysfs: cannot create duplicate filename '/bus/soundwire/devices/sdw:0:0217:0204:00:0'
>
> The link ID is 0 for both devices, so they should be differentiated by
> the controller ID. Add the controller ID so, the device names and sysfs entries look
> like:
>
> sdw:1:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6ab0000.soundwire-controller/sdw-master-1-0/sdw:1:0:0217:0204:00:0
> sdw:3:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6b10000.soundwire-controller/sdw-master-3-0/sdw:3:0:0217:0204:00:0
>
> [PLB changes: use bus->controller_id instead of bus->id]
>
> Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
> Cc: <stable@vger.kernel.org>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> Co-developed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
The order of SoB is not correct. Author's goes before co-developed.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-23 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 16:09 [RFC PATCH 0/2] soundwire: introduce controller ID Pierre-Louis Bossart
2023-10-17 16:09 ` [RFC PATCH 1/2] soundwire: bus: introduce controller_id Pierre-Louis Bossart
2023-10-17 16:12 ` kernel test robot
2023-11-23 10:50 ` Srinivas Kandagatla
2023-11-23 10:57 ` Krzysztof Kozlowski
2023-10-17 16:09 ` [RFC PATCH 2/2] soundwire: fix initializing sysfs for same devices on different buses Pierre-Louis Bossart
2023-10-17 16:29 ` Mark Brown
2023-11-23 10:58 ` Krzysztof Kozlowski [this message]
2023-11-23 10:50 ` [RFC PATCH 0/2] soundwire: introduce controller ID Srinivas Kandagatla
2023-11-24 6:58 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479c16ce-da90-4571-bd08-b592d63f06cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=pombredanne@nexb.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox