From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6375931E107 for ; Thu, 7 May 2026 04:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778126954; cv=none; b=MWy6cFEjNDJjWCf1Tb6YALjoBYxs3qnfm0rlWHQ95xKzyg3sMmDvtwbPSrTp0uNsQUbXtZAmU6A4biqmUI5FM0GgW2Pexq7g20RxfeS/y+kfPvKuhfIFn727hEdNPuxAKDXO+uUGO5STAcItlE+HEjxsZL3u1W+QiwLSBWDiGHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778126954; c=relaxed/simple; bh=WtUC1agCPDh8q1OptnVFSZ0gqakui8D6ahrqHsh7bgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qfIDCTNed+thn24TBsP5G8Jm2bdmEYEW2RdawKbBGwOhuOjr0EnR3DwybF222f6btRgCSKAnfD4xPqdeDm99es4m/+pZfYToNUFhTBrf5105ajmEZXKP6f/xkyVMvE8V+k11Q5ajjzaW7rG4Ufc21HkCRtkKujfPPSbz9Va2Zqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NKiR+Hwz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NS+xtHTt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NKiR+Hwz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NS+xtHTt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6472L93n3463973 for ; Thu, 7 May 2026 04:09:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WtUC1agCPDh8q1OptnVFSZ0gqakui8D6ahrqHsh7bgE=; b=NKiR+Hwz8aKEPHp7 AptYX0puDPEhB3byWywfEZausfD2zBMbOP3JHCweT9/MPM34srzc9W8Pn/+8OGvS Z1QL8Ol+jT/Y/6QUvbOjqEYI2+I+ZHMEzB7UrTE5soHOiCVyDDCBAXGny1hHkySh zrfM8xy855ZktFYZHArnofd7o5nnXQLyJJYQnT46wQwnPXeHMgIUSSiDH2tgyr3T E7Eguvxq2LbdOzoNxnImvFd+xKb0w7Fwtr9KVPpB9tSkGfjtGBMVJtohDblmKEoZ z02Qk8j2o3kpvd/4dzMxUOvwXwRn2aFdpalvqn5vR26DTmJUWyEeBR2Qey3LHROR 5DfjFg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hvn09bx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 04:09:11 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-365faf6006dso453901a91.1 for ; Wed, 06 May 2026 21:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778126951; x=1778731751; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WtUC1agCPDh8q1OptnVFSZ0gqakui8D6ahrqHsh7bgE=; b=NS+xtHTtvJun8P4dsXgrkEH61E9LKPSIQmlp+4aBMjfn+WG+q9jVoIp3ylibUQlD+4 yQ495Zo+hbNZ+glFI6z1+tsc0m13hiNfixiYBCYZcM5P6n/LpWZtFiQA3kF5V4wF21/X N31W7AZSaX9JQZt8gyJrpWfuCARPUX6ZoZvK4V99bUvZbsDPMkjE2JQ/LQAs6LgwXjhb VFu4D/6I4BpHuNUtn7eAfy+jCzBpHxTFtt7zIEWRvkjNLH1ehzM7Oo10xqTjW5daDUHR nLVXnK6ZNXbhp+TnYZnmvV8iLBO5ek7XyP1dW+OBAPcW+DQl/bWAs0HyqhlDKj0NxqwB cxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778126951; x=1778731751; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WtUC1agCPDh8q1OptnVFSZ0gqakui8D6ahrqHsh7bgE=; b=NBPdR80p4g8v8BBEAbVqEQvRnEKj7jkxmbeHf8BA07mDpyeVSs7QXF20VE6EnFD+8o 5FXjekW3vvnQyHjJcHIkhHj1d1VG+ct5hGlI/SvQ4TyGMzNqAsTAGkL7dIa1IkSp9q7y 0/b+tLdsWDO0qHoQNAFFHUOYLMBy1966muM9veriHZaj96r9wPULLZ7xcqt542z6+Dch fNLS9W8pV365ExTDAIp8NCLgSoUIQoxsPrqXy+Jg5x+iitxEcaDaAY6pp8kBWpOQRFzW nFO/A5u1trrqEUgwrdc+lDyoU7t7+rNSWi6WkMSlX3j8KMQYhcX/Vs9eXOt/BquPSev7 Th1A== X-Forwarded-Encrypted: i=1; AFNElJ+tJQL2uxJB1j5dhIUTb4nH8DNhr91HZOzlFrs+4ieuX0EWhKhlQb4sPO802K3cSl1QT7U9ywQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwdRYnILuwVgu7+4ZHhE7f8N+hnuJpQ+Y3WZf3yUwB+G+NM3uCN FhiAh3C/COt+XTpFGkqOjlEMk+0Fu9VSl6IkdwWQ3MoQEUVVoWJAsXn/4UsN/3Ra8L7Wx/VWXZY SbjAh02dvdeg1uCWLSSW0v8Y5dSzqZwv/0uBX62o+OswcPlIFn7A8HglS0A0= X-Gm-Gg: AeBDievZSHtRstLn7C2U3HfDQa2L6pu2DasSAdh8CfZ+wEPOeFpzww588f7b9Gq9KkM jXQdiqbGwcZYISRcaA4veLwRcK0WZ4gPFsXCTj9oCNcN3x/nNyakz0PxOGFh8cDXXWewzLDhsr0 cE0jlMyK/Dffd6/9StpbUIdlES72KtXXx/kwQjRWFBhfqJcyXlftxwz1tntMLcQvEfmr/mceUnB V8zxwpxYz5BL0RwJZMp8GRaxJixdk2TBMt1pMROASjjES7L4hnM5IPQ2nXU4AH3afwiO8qvD55d E4j0ttuzXhUdT9GMqnE5FC5yoQpE7OIjTkSbXGWNum5vQ564shyNO4rFOazKkR+lu2NoA+vWKFt oZR02KnpwTwlOH8iWasSlY4VwmAD1T8YIBNHbAUkSgz3+pSS054uk6sVr802K X-Received: by 2002:a17:90b:134d:b0:33b:b078:d6d3 with SMTP id 98e67ed59e1d1-365ac7757cemr6881543a91.23.1778126950764; Wed, 06 May 2026 21:09:10 -0700 (PDT) X-Received: by 2002:a17:90b:134d:b0:33b:b078:d6d3 with SMTP id 98e67ed59e1d1-365ac7757cemr6881514a91.23.1778126950094; Wed, 06 May 2026 21:09:10 -0700 (PDT) Received: from [10.218.34.110] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babadef249sm8030845ad.59.2026.05.06.21.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 21:09:09 -0700 (PDT) Message-ID: <4809a7f7-8ec1-4f72-9154-8ca01111f4a5@oss.qualcomm.com> Date: Thu, 7 May 2026 09:39:04 +0530 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: Unconditionally mark gpio as wakeup enable To: Linus Walleij Cc: Bjorn Andersson , Neil Armstrong , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260430-enable_wakeup_capable_gpios-v1-1-5de39bf06094@oss.qualcomm.com> Content-Language: en-US From: Sneh Mankad In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzNyBTYWx0ZWRfX+YXGtO+70F1b 44qxljyAlrr5qBpou7N1f1/3Wq47nUbYcih/3BxhGOUhPX6g2SJaY2FlKF91VeZE181OyIuP1bl JDpEZ5Dvr+eXaBlBpn6R0H6h7ojfwERlhnOG+fmESYq+jsoJOvAuUGPCGC8ML2TIxbHGIrWWZQQ ydf+MwV8Oq/fNCQSTxyk+qwFNF07FI6liTZM9EypT1Am+N5fBUozGWveyydXcAPr2o45gb4ayV9 0mhRVbGUxjWi3dNg9m0ZIYwyJCqERTYSqfdKzrGIUBsswsFkFdsjyK2Ja7uS+GmMygtqcFA7+BE m+IUV0MAXZDNizWa3d1umPJXLR+CU2SvbAnd+1K3Gs98tsxKoUaipHAUWp1gWmxWLAwsJ97Lexi 01Ejs1eCWfuPwLBErUzW2iEJpdRLTWTVD4vvirM7INwdiKoD4/tY+1sDEDmLchW9YAwxmO1sv/m mTz7VFHoZardYtg672g== X-Proofpoint-ORIG-GUID: uTGWl52Ep8C342z23wXo-yLH9rw7NuxI X-Proofpoint-GUID: uTGWl52Ep8C342z23wXo-yLH9rw7NuxI X-Authority-Analysis: v=2.4 cv=ZZ4t8MVA c=1 sm=1 tr=0 ts=69fc1067 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=_3-bX4vkxkCJ1edF7K4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070037 On 05-May-26 3:58 PM, Linus Walleij wrote: > On Thu, Apr 30, 2026 at 7:54 AM Sneh Mankad > wrote: > >> The wakeup enable bit needs to be set irrespective of the SoC using PDC or >> MPM as wakeup capable irqchip to allow the GPIO interrupts to be forwarded >> to parent irqchip. >> >> This is set only for PDC irqchip using additional check skip_wake_irqs >> making it impossible for MPM irqchip to detect the GPIO interrupt during >> SoC low power mode since for MPM irqchip the skip_wake_irqs is always >> false. >> >> Remove skip_wake_irqs condition when setting wakeup enable bit to allow >> forwarding GPIO interrupts for SoCs using MPM irqchip too. >> >> Fixes: 76b446f5b86e ("pinctrl: qcom: handle intr_target_reg wakeup_present/enable bits") >> Signed-off-by: Sneh Mankad > Good work here, also super-dangerous so if some more Qualcomm > engineers could pitch in on this patch it'd be great. > > Is this an urgent (-rc) or nonurgent (next) fix? > > Yours, > Linus Walleij Its fine if it gets picked in the next release. Thanks Sneh