From: Paul Walmsley <pjw@kernel.org>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: kernel test robot <lkp@intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Cyril Bur <cyrilbur@tenstorrent.com>,
Jisheng Zhang <jszhang@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] riscv: Fix sparse warning about different address spaces
Date: Fri, 19 Sep 2025 18:55:59 -0600 (MDT) [thread overview]
Message-ID: <485fba52-1f41-e940-bc38-2e2244d78c76@kernel.org> (raw)
In-Reply-To: <20250903-dev-alex-sparse_warnings_v1-v1-2-7e6350beb700@rivosinc.com>
On Wed, 3 Sep 2025, Alexandre Ghiti wrote:
> We did not propagate the __user attribute of the pointers in
> __get_kernel_nofault() and __put_kernel_nofault(), which results in
> sparse complaining:
>
> >> mm/maccess.c:41:17: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got unsigned long long [usertype] * @@
> mm/maccess.c:41:17: sparse: expected void const [noderef] __user *from
> mm/maccess.c:41:17: sparse: got unsigned long long [usertype] *
>
> So fix this by correctly casting those pointers.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508161713.RWu30Lv1-lkp@intel.com/
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Fixes: f6bff7827a48 ("riscv: uaccess: use 'asm_goto_output' for get_user()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Thanks, this one was sent upstream as part of the last fixes PR.
- Paul
next prev parent reply other threads:[~2025-09-20 0:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 18:53 [PATCH 0/2] Fix riscv sparse warnings Alexandre Ghiti
2025-09-03 18:53 ` [PATCH 1/2] riscv: Fix sparse warning in __get_user_error() Alexandre Ghiti
2025-09-04 0:34 ` Cyril Bur
2025-09-04 13:50 ` Clément Léger
2025-09-05 22:14 ` Paul Walmsley
2025-09-20 0:55 ` Paul Walmsley
2025-09-03 18:53 ` [PATCH 2/2] riscv: Fix sparse warning about different address spaces Alexandre Ghiti
2025-09-04 0:42 ` Cyril Bur
2025-09-05 6:29 ` Clément Léger
2025-09-05 22:15 ` Paul Walmsley
2025-09-20 0:55 ` Paul Walmsley [this message]
2025-09-17 2:40 ` [PATCH 0/2] Fix riscv sparse warnings patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485fba52-1f41-e940-bc38-2e2244d78c76@kernel.org \
--to=pjw@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=cyrilbur@tenstorrent.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox