From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D5263334374; Mon, 20 Apr 2026 11:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683903; cv=none; b=VmdsE7clbHEECQax5mKBT5QrIJwwnn2mgs/7TqKLKx8Q9xyVL0a6+/RTIXPyRDlXOMiMwKjU8Ktu2gr6aygiZ7uLFlrounG68cadwE1DcQagR6eEwkAANl90umW0oRaiQcB8XcUvLPvchaMaK2XV5FabF7AmYhvopJrxo5203H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683903; c=relaxed/simple; bh=eDjCLpVfQ9c2PFa8mDoqqBedTvS6p99mksjDimWJylo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JSQ71t54zssW1FQizGeVfWo6HT0S08O2+Cx+F6+77qDMJBq6sEwAQymx0+0ip770t4NTGpryAeneErRNqZJXlKBonwUYfdJ5GKaIYH1bQ7FRL3/LHDUIY8Vz9I6wGDGCLdhRhDtrD4XNzMv7u1G/Km3/KijcJMVpdHuiWA/3+Zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=vbeHqt8h; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="vbeHqt8h" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0ED61516; Mon, 20 Apr 2026 04:18:15 -0700 (PDT) Received: from [10.57.32.80] (unknown [10.57.32.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CB2D3F641; Mon, 20 Apr 2026 04:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776683901; bh=eDjCLpVfQ9c2PFa8mDoqqBedTvS6p99mksjDimWJylo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vbeHqt8hcNjMtrvOPqFVKZ7p1MPb1UOM9FleKPMsBJD+kY/Invg4xoMDqPO9bQ/RN RJrU+VLX65fMl4Rp2CzFLlMqg4OAhCNK9eVngfsH9PcFIZHVLZ5oxQTBoCdXggb4UP XKSYcRIiKL1R3OrIwU1qBQFRPTgdjEIBOymiw6AU= Message-ID: <48a13e98-ac6c-42d3-98f6-a8d77b349c3d@arm.com> Date: Mon, 20 Apr 2026 12:18:15 +0100 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] drm/panfrost: Fix wait_bo ioctl leaking positive return from dma_resv_wait_timeout() To: Gyeyoung Baek , Tomeu Vizoso , Boris Brezillon , Rob Herring , =?UTF-8?Q?Adri=C3=A1n_Larumbe?= Cc: Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: From: Steven Price Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/04/2026 08:17, Gyeyoung Baek wrote: > dma_resv_wait_timeout() returns a positive 'remaining jiffies' value > on success, 0 on timeout, and -errno on failure. > > panfrost_ioctl_wait_bo() returns this 'long' result from an int-typed > ioctl handler, so positive values reach userspace as bogus errors. > Explicitly set ret to 0 on the success path. > > Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") > Cc: stable@vger.kernel.org > Signed-off-by: Gyeyoung Baek Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 3d0bdba2a..784e36d72 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -390,6 +390,8 @@ panfrost_ioctl_wait_bo(struct drm_device *dev, void *data, > true, timeout); > if (!ret) > ret = timeout ? -ETIMEDOUT : -EBUSY; > + else if (ret > 0) > + ret = 0; > > drm_gem_object_put(gem_obj); >