Re: [PATCH 5.10.y] block: add overflow checks for Amiga partition support

[Michael Schmitz <schmitzmic@gmail.com>]

Thanks Greg!

On 17/07/23 03:21, Greg KH wrote:
> On Sun, Jul 16, 2023 at 11:28:20AM +1200, Michael Schmitz wrote:
>> The Amiga partition parser module uses signed int for partition sector
>> address and count, which will overflow for disks larger than 1 TB.
>>
>> Use u64 as type for sector address and size to allow using disks up to
>> 2 TB without LBD support, and disks larger than 2 TB with LBD. The RBD
>> format allows to specify disk sizes up to 2^128 bytes (though native
>> OS limitations reduce this somewhat, to max 2^68 bytes), so check for
>> u64 overflow carefully to protect against overflowing sector_t.
>>
>> Bail out if sector addresses overflow 32 bits on kernels without LBD
>> support.
>>
>> This bug was reported originally in 2012, and the fix was created by
>> the RDB author, Joanne Dow <jdow@earthlink.net>. A patch had been
>> discussed and reviewed on linux-m68k at that time but never officially
>> submitted (now resubmitted as patch 1 in this series).
>> This patch adds additional error checking and warning messages.
>>
>> Reported-by: Martin Steigerwald <Martin@lichtvoll.de>
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=43511
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Message-ID: <201206192146.09327.Martin@lichtvoll.de>
>> Cc: <stable@vger.kernel.org> # 5.2
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Reviewed-by: Christoph Hellwig <hch@infradead.org>
>> Link: https://lore.kernel.org/r/20230620201725.7020-4-schmitzmic@gmail.com
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> (cherry picked from commit b6f3f28f604ba3de4724ad82bea6adb1300c0b5f)
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>>
>> ---
>>
>> Changes since 5.10-stable:
>>
>> - fix merge conflicts
>> ---
> All now queued up, thanks.
>
> greg k-h
Just to clarify: that does include

https://git.kernel.dk/cgit/linux/commit/?h=block-6.5&id=7eb1e47696aa231b1a567846bbe3a1e1befe1854

queued up by Jens, which does not have a stable tag (as per our 
discussion earlier)?

Link: https://lore.kernel.org/r/2023070456-vertigo-fanfare-1a8e@gregkh
Link: https://lore.kernel.org/r/c9bcd3ca-8260-3f29-26d1-0c00e2b098a3@kernel.dk

Cheers,

     Michael