From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, linux-sound@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Jaroslav Kysela <perex@perex.cz>,
Julia Lawall <Julia.Lawall@inria.fr>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out_ctls()
Date: Thu, 13 Feb 2025 08:26:09 +0100 [thread overview]
Message-ID: <491e74f2-b503-4486-a8e0-b4eddc16b2be@web.de> (raw)
In-Reply-To: <20250213070546.1572-1-vulab@iscas.ac.cn>
> Check the return value of snd_ctl_rename_id() in
> snd_hda_create_dig_out_ctls(). Ensure that potential
> failures are properly handled.
I would prefer a change description variant without the word “potential”
for this issue.
https://cwe.mitre.org/data/definitions/252.html
Regards,
Markus
next prev parent reply other threads:[~2025-02-13 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 7:05 [PATCH] ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out_ctls() Wentao Liang
2025-02-13 7:26 ` Markus Elfring [this message]
2025-02-13 9:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491e74f2-b503-4486-a8e0-b4eddc16b2be@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@inria.fr \
--cc=cezary.rojewski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox