Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "zhen.ni" <zhen.ni@easystack.cn>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] pidfs: fix ERR_PTR dereference in pidfd_info()
Date: Mon, 13 Oct 2025 11:42:39 +0800	[thread overview]
Message-ID: <49645a87-b785-4538-8615-ff5b4a36d605@easystack.cn> (raw)
In-Reply-To: <5asnajyk3d4c66fnpmodybc7rrprhvw4jy2chrihnlcgylu5uf@hfcw24zm2w7k>


在 2025/10/11 17:24, Mateusz Guzik 写道:
> 
> Is that something you ran into or perhaps you are going off of reading
> the code?
> 
> The only way that I see to get here requires a file with
> pidfs_file_operations, so AFAICS this shouuld never trigger.
> 
> In the worst case perhaps this can WARN_ON?
> 
> 

Thanks for the review.

I did not hit this in real testing, but only inferred the potential 
issue from reading the code context. After taking another look at the 
call paths into pidfd_info(), I agree this is indeed an over-defensive 
check and not actually reachable.

I'll drop this patch. Thanks for the clarification.

Zhen

      reply	other threads:[~2025-10-13  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-11  7:29 [PATCH] pidfs: fix ERR_PTR dereference in pidfd_info() Zhen Ni
2025-10-11  9:24 ` Mateusz Guzik
2025-10-13  3:42   ` zhen.ni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49645a87-b785-4538-8615-ff5b4a36d605@easystack.cn \
    --to=zhen.ni@easystack.cn \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox