stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stratos Psomadakis <psomas@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, gregkh@suse.de,
	linux-scsi@vger.kernel.org, JBottomley@parallels.com,
	matthew@wil.cx, Martin.vGagern@gmx.net, kernel@gentoo.org
Subject: [SCSI] NULL pointer dereference in sym53c8xx (bisected)
Date: Fri, 02 Dec 2011 17:26:20 +0200	[thread overview]
Message-ID: <4ED8EE1C.4090404@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Hi,

After upstream commit 4e6c82b3614a18740ef63109d58743a359266daf ([SCSI]
fix WARNING: at drivers/scsi/scsi_lib.c:1704), which is also included in
3.0-stable and 3.1-stable kernels, the kernel fails to boot (NULL
pointer dereference in sym53c8xx_slave_destroy).

Bug report at the Gentoo Bugzilla (reported and bisected by Martin von
Gagern). [1]  (stack trace [2])

I think that the problem is that (after commit 4e6c82b)
__scsi_remove_device() is called if slave_alloc() in scsi_alloc_sdev()
fails. But __scsi_remove_device() calls slave_destroy(), which (I think)
doesn't make much sense (ie to call slave_destroy() when slave_alloc()
fails).

For sym53c8xx, this results in a NULL pointer dereference (struct
sym_lcb pointer) in slave_destroy().

[1] https://bugs.gentoo.org/show_bug.cgi?id=392567
[2] https://392567.bugs.gentoo.org/attachment.cgi?id=294381

-- 
Stratos Psomadakis
<psomas@gentoo.org>



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

             reply	other threads:[~2011-12-02 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02 15:26 Stratos Psomadakis [this message]
2011-12-03 21:07 ` [SCSI] NULL pointer dereference in sym53c8xx (bisected) Steffen Maier
2011-12-04  0:11   ` Stratos Psomadakis
2011-12-04 17:36     ` Stratos Psomadakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED8EE1C.4090404@gentoo.org \
    --to=psomas@gentoo.org \
    --cc=JBottomley@parallels.com \
    --cc=Martin.vGagern@gmx.net \
    --cc=gregkh@suse.de \
    --cc=kernel@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).