From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <4EDFA9D6.5050907@zytor.com>
Date: Wed, 07 Dec 2011 10:00:54 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
MIME-Version: 1.0
To: Linus Torvalds <torvalds@linux-foundation.org>
CC: Greg KH <gregkh@suse.de>, Ingo Molnar <mingo@elte.hu>,
	Brian Gerst <brgerst@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
	Tim Blechmann <tim@klingt.org>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [20/80] ALSA: lx6464es - fix device communication via command
 bus
References: <20111207161256.GA7736@kroah.com> <20111207160824.268488820@clark.kroah.org> <CA+55aFwzdXwLJjUL_i247exawkzqdoCULXg81qzG4Ewn7ysn3A@mail.gmail.com>
In-Reply-To: <CA+55aFwzdXwLJjUL_i247exawkzqdoCULXg81qzG4Ewn7ysn3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 12/07/2011 09:47 AM, Linus Torvalds wrote:
> 
> Ingo, Peter, Thomas? Comments?
> 

I agree in principle, although I am really not happy about the idea of
disallowing 64-bit writes from device drivers that haven't explicitly
indicated they won't support it.

However, I would *also* like if more drivers would explicitly specify
the transfer size they expect.  Right now, that is done though a set of
functions whose name are a bit of a mismatch to the others:
__iowrite{32,64}_copy(), which probably should be renamed
memcpy_toio{32,64}() and augmented with matching memcpy_fromio{32,64}()
functions.

What do you think?

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.