From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Raphael Prevost <raphael@buro.asia>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] i387: stable kernel backport
Date: Wed, 22 Feb 2012 14:34:55 -0800 [thread overview]
Message-ID: <4F456D8F.1080801@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1202221252060.20522@i5.linux-foundation.org>
On 02/22/2012 12:54 PM, Linus Torvalds wrote:
>
> This is a reasonably minimal backport of the i387 state save/restore bug.
>
> A few of the commits are just minimal "make it easier to backport" commits
> that don't necessarily fix anything on their own. And a few of the others
> are combinations of what is two commits in the development tree, because
> it turned out to be easier and cleaner that way.
>
> The last one is the one that fixes the x86-32 bug, but the preemption
> fixes are real fixes too, although they are probably not something that
> anybody has necessarily ever hit in reality because the race window is so
> small. Even so, if the fix itself isn't that important, the "make it
> easier to backport the main one" would still be a big argument for it.
>
> I *really* hope that the people who could reproduce this bug will test the
> back-port series too, since I never actually saw the bug personally to
> begin with. And again, big thanks to Raphael who helped pinpoint and debug
> this.
>
Okay, this patchset does *NOT* work. It fails immediately on my system.
I hadn't ever seen it fail so fast.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-02-22 22:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 20:54 [PATCH 0/5] i387: stable kernel backport Linus Torvalds
2012-02-22 20:56 ` [PATCH 1/5] i387: math_state_restore() isn't called from asm Linus Torvalds
2012-02-22 20:56 ` [PATCH 2/5] i387: make irq_fpu_usable() tests more robust Linus Torvalds
2012-02-22 20:57 ` [PATCH 3/5] i387: fix x86-64 preemption-unsafe user stack save/restore Linus Torvalds
2012-02-22 20:58 ` [PATCH 4/5] i387: move TS_USEDFPU clearing out of __save_init_fpu and into callers Linus Torvalds
2012-02-22 20:59 ` [PATCH 5/5] i387: move TS_USEDFPU flag from thread_info to task_struct Linus Torvalds
2012-02-22 21:02 ` [PATCH 0/5] i387: stable kernel backport H. Peter Anvin
2012-02-22 21:19 ` Greg Kroah-Hartman
2012-02-22 21:29 ` Linus Torvalds
2012-02-22 21:30 ` Linus Torvalds
2012-02-22 21:32 ` Greg Kroah-Hartman
2012-02-23 20:09 ` Greg Kroah-Hartman
2012-02-23 20:29 ` H. Peter Anvin
2012-02-23 20:48 ` Greg Kroah-Hartman
2012-02-23 20:51 ` H. Peter Anvin
2012-02-23 21:10 ` Greg Kroah-Hartman
2012-02-23 21:52 ` Willy Tarreau
2012-02-23 22:11 ` Linus Torvalds
2012-02-23 22:27 ` Willy Tarreau
2012-02-23 22:38 ` Linus Torvalds
2012-02-23 22:48 ` H. Peter Anvin
2012-02-23 22:52 ` Willy Tarreau
2012-02-23 22:55 ` H. Peter Anvin
2012-02-23 23:04 ` Willy Tarreau
2012-02-23 22:49 ` Willy Tarreau
2012-02-23 22:59 ` Greg Kroah-Hartman
2012-02-23 23:05 ` H. Peter Anvin
2012-02-23 23:16 ` Greg Kroah-Hartman
2012-02-23 23:18 ` H. Peter Anvin
2012-02-23 23:19 ` Suresh Siddha
2012-02-23 23:54 ` Greg Kroah-Hartman
2012-02-23 23:59 ` H. Peter Anvin
2012-02-24 0:47 ` H. Peter Anvin
2012-02-22 22:34 ` H. Peter Anvin [this message]
2012-02-22 22:45 ` H. Peter Anvin
2012-02-22 23:15 ` Linus Torvalds
2012-02-22 23:31 ` Linus Torvalds
2012-02-23 0:14 ` H. Peter Anvin
2012-02-23 0:25 ` Linus Torvalds
2012-02-23 0:37 ` Greg Kroah-Hartman
2012-02-23 1:47 ` raphael
2012-02-23 2:55 ` Linus Torvalds
2012-02-23 2:41 ` raphael
2012-02-23 3:37 ` Linus Torvalds
2012-02-23 18:15 ` Greg Kroah-Hartman
2012-02-23 19:36 ` Greg Kroah-Hartman
2012-02-23 19:41 ` Linus Torvalds
2012-02-23 19:50 ` Greg Kroah-Hartman
2012-02-23 19:55 ` Greg Kroah-Hartman
2012-02-23 20:02 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F456D8F.1080801@zytor.com \
--to=hpa@zytor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raphael@buro.asia \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).