From: Jiri Slaby <jslaby@suse.cz>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, stable@vger.kernel.org,
lwn@lwn.net, Tony Luck <tony.luck@intel.com>,
Jiri Slaby <jirislaby@gmail.com>,
raven@themaw.net
Subject: Re: Build broken on s390 and ia64 [was: Linux 2.6.32.58]
Date: Mon, 05 Mar 2012 13:48:24 +0100 [thread overview]
Message-ID: <4F54B618.1090301@suse.cz> (raw)
In-Reply-To: <20120305120241.GA3627@osiris.boeblingen.de.ibm.com>
On 03/05/2012 01:02 PM, Heiko Carstens wrote:
> On Mon, Mar 05, 2012 at 12:32:58PM +0100, Jiri Slaby wrote:
>> Perhaps asm/compat.h should be included from linux/compat.h
>> unconditionally...
>
> If you do that you need to add #ifdef wrappers around the is_compat_task()
> definitions in each arch that supports CONFIG_COMPAT. If that's all that's
> needed that would be great!
I don't know, I haven't checked. It was just a shot in the dark. Maybe
it's easier to revert the removal of asm/compat.h from s390 files. Could
you bake a patch?
>>> Linus Torvalds (2): Fix autofs compile without CONFIG_COMPAT
>>
>> But who defines is_compat_task *with* CONFIG_COMPAT on ia64?
>>
>> fs/autofs4/inode.c: In function 'autofs4_fill_super':
>> fs/autofs4/inode.c:345: error: implicit declaration of function
>> 'is_compat_task'
>
> The ia64 compat code got entirely removed, since it was broken:
>
> 32974ad4907cdde6c9de612cd1b2ee0568fb9409 "[IA64] Remove COMPAT_IA32 support"
Yes, but that is even in 2.6.34. So the fix for autofs is incomplete in
.32 as it breaks build on configs which used to work.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-03-05 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 18:09 Linux 2.6.32.58 Greg KH
2012-03-04 18:09 ` Greg KH
2012-03-04 23:22 ` Willy Tarreau
2012-03-05 11:32 ` Build broken on s390 and ia64 [was: Linux 2.6.32.58] Jiri Slaby
2012-03-05 12:02 ` Heiko Carstens
2012-03-05 12:48 ` Jiri Slaby [this message]
2012-03-05 12:54 ` Willy Tarreau
2012-03-05 12:56 ` Jiri Slaby
2012-03-05 13:13 ` Heiko Carstens
2012-03-05 13:18 ` Willy Tarreau
2012-03-05 22:33 ` Willy Tarreau
2012-03-08 11:06 ` Jiri Slaby
2012-03-08 11:47 ` Willy Tarreau
2012-03-09 5:29 ` Ben Hutchings
2012-03-09 6:57 ` Willy Tarreau
2012-03-09 8:23 ` Jiri Slaby
2012-03-09 8:41 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54B618.1090301@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=raven@themaw.net \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).