From: Joe Jin <joe.jin@oracle.com>
To: Junxiao Bi <junxiao.bi@oracle.com>
Cc: ocfs2-devel@oss.oracle.com, linux-aio@kvack.org,
mfasheh@suse.com, jlbec@evilplan.org, bcrl@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
David John Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH 2/2] ocfs2: clear unaligned io flag when dio fails
Date: Thu, 31 May 2012 12:36:47 +0800 [thread overview]
Message-ID: <4FC6F55F.7040507@oracle.com> (raw)
In-Reply-To: <1338437550-24499-2-git-send-email-junxiao.bi@oracle.com>
Cc David.
On 05/31/12 12:12, Junxiao Bi wrote:
> The unaligned io flag is set in the kiocb when an unaligned
> dio is issued, it should be cleared even when the dio fails,
> or it may affect the following io which are using the same
> kiocb.
>
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> ---
> fs/ocfs2/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 061591a..98513c8 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2422,8 +2422,10 @@ out_dio:
> unaligned_dio = 0;
> }
>
> - if (unaligned_dio)
> + if (unaligned_dio) {
> + ocfs2_iocb_clear_unaligned_aio(iocb);
> atomic_dec(&OCFS2_I(inode)->ip_unaligned_aio);
> + }
>
> out:
> if (rw_level != -1)
--
Oracle <http://www.oracle.com>
Joe Jin | Software Development Senior Manager | +8610.6106.5624
ORACLE | Linux and Virtualization
No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing
next prev parent reply other threads:[~2012-05-31 4:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 4:12 [PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb() Junxiao Bi
2012-05-31 4:12 ` [PATCH 2/2] ocfs2: clear unaligned io flag when dio fails Junxiao Bi
2012-05-31 4:36 ` Joe Jin [this message]
2012-05-31 14:09 ` Jeff Moyer
2012-06-01 1:44 ` Junxiao Bi
2012-05-31 4:36 ` [PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb() Joe Jin
2012-05-31 14:08 ` Jeff Moyer
2012-06-01 1:41 ` Junxiao Bi
2012-06-01 20:55 ` Jeff Moyer
2012-06-02 2:59 ` Junxiao Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC6F55F.7040507@oracle.com \
--to=joe.jin@oracle.com \
--cc=bcrl@kvack.org \
--cc=dave.kleikamp@oracle.com \
--cc=jlbec@evilplan.org \
--cc=junxiao.bi@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).