From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FC71496.8050707@gmail.com> Date: Thu, 31 May 2012 02:49:58 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 To: Christoph Lameter CC: KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Dave Jones , Mel Gorman , Linus Torvalds , stable@vger.kernel.org, hughd@google.com, Andrew Morton , KOSAKI Motohiro Subject: Re: [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages" References: <1338368529-21784-1-git-send-email-kosaki.motohiro@gmail.com> <1338368529-21784-2-git-send-email-kosaki.motohiro@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: (5/30/12 3:17 PM), Christoph Lameter wrote: > On Wed, 30 May 2012, kosaki.motohiro@gmail.com wrote: > >> From: KOSAKI Motohiro >> >> commit 05f144a0d5 removed vma->vm_policy updates code and it is a purpose of >> mbind_range(). Now, mbind_range() is virtually no-op. no-op function don't >> makes any bugs, I agree. but maybe it is not right fix. > > I dont really understand the changelog. But to restore the policy_vma() is > the right thing to do since there are potential multiple use cases where > we want to apply a policy to a vma. > > Proposed new changelog: > > Commit 05f144a0d5 folded policy_vma() into mbind_range(). There are > other use cases of policy_vma(*) though and so revert a piece of > that commit in order to have a policy_vma() function again. sorry, I overlooked this. Commit 05f144a0d5 don't work neither regular vma nor shmem vma. thus I can't take this proposal. sorry.