* [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ [not found] ` <201206111531.20468.arnd@arndb.de> @ 2012-06-12 8:57 ` Lee Jones 2012-06-13 22:25 ` Andrew Morton 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2012-06-12 8:57 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, linux-kernel, linus.walleij, grant.likely, Alessandro Zummo, rtc-linux, stable From: Lee Jones <lee.jones@linaro.org> Date: Tue, 22 May 2012 15:25:09 +0100 Subject: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: rtc-linux@googlegroups.com Cc: stable@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/rtc/rtc-ab8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 4bcf9ca..b11a2ec 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -422,7 +422,7 @@ static int __devinit ab8500_rtc_probe(struct platform_device *pdev) } err = request_threaded_irq(irq, NULL, rtc_alarm_handler, - IRQF_NO_SUSPEND, "ab8500-rtc", rtc); + IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc); if (err < 0) { rtc_device_unregister(rtc); return err; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ 2012-06-12 8:57 ` [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ Lee Jones @ 2012-06-13 22:25 ` Andrew Morton 2012-06-14 7:14 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Andrew Morton @ 2012-06-13 22:25 UTC (permalink / raw) To: Lee Jones Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, linus.walleij, grant.likely, Alessandro Zummo, rtc-linux, stable On Tue, 12 Jun 2012 09:57:37 +0100 Lee Jones <lee.jones@linaro.org> wrote: > The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. What does this mean. The kernel crashes? The registration fails? A warning is emitted? When fixing a bug, please fully describe the consequences of that bug. > Cc: stable@vger.kernel.org Especially when suggesting a -stable backport. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ 2012-06-13 22:25 ` Andrew Morton @ 2012-06-14 7:14 ` Lee Jones 2012-06-14 7:30 ` Andrew Morton 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2012-06-14 7:14 UTC (permalink / raw) To: Andrew Morton Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, linus.walleij, grant.likely, Alessandro Zummo, rtc-linux, stable On 13/06/12 23:25, Andrew Morton wrote: > On Tue, 12 Jun 2012 09:57:37 +0100 > Lee Jones<lee.jones@linaro.org> wrote: > >> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. > > What does this mean. The kernel crashes? The registration fails? A > warning is emitted? > > When fixing a bug, please fully describe the consequences of that bug. > >> Cc: stable@vger.kernel.org > > Especially when suggesting a -stable backport. No problem. I'll try to remember that for next time. I see that you've taken the patch into your tree however. So do you want me to update the commit log and resubmit, or are you going to 'let this one slide'? -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ 2012-06-14 7:14 ` Lee Jones @ 2012-06-14 7:30 ` Andrew Morton 2012-06-14 8:02 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Andrew Morton @ 2012-06-14 7:30 UTC (permalink / raw) To: Lee Jones Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, linus.walleij, grant.likely, Alessandro Zummo, rtc-linux, stable On Thu, 14 Jun 2012 08:14:49 +0100 Lee Jones <lee.jones@linaro.org> wrote: > On 13/06/12 23:25, Andrew Morton wrote: > > On Tue, 12 Jun 2012 09:57:37 +0100 > > Lee Jones<lee.jones@linaro.org> wrote: > > > >> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. > > > > What does this mean. The kernel crashes? The registration fails? A > > warning is emitted? > > > > When fixing a bug, please fully describe the consequences of that bug. > > > >> Cc: stable@vger.kernel.org > > > > Especially when suggesting a -stable backport. > > No problem. I'll try to remember that for next time. > > I see that you've taken the patch into your tree however. So do you want > me to update the commit log and resubmit, or are you going to 'let this > one slide'? Please read my emails - they're very nice! "What does this mean. The kernel crashes? The registration fails? A warning is emitted?". You answer that, I copy-n-paste into changelog and we're done. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ 2012-06-14 7:30 ` Andrew Morton @ 2012-06-14 8:02 ` Lee Jones 0 siblings, 0 replies; 6+ messages in thread From: Lee Jones @ 2012-06-14 8:02 UTC (permalink / raw) To: Andrew Morton Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, linus.walleij, grant.likely, Alessandro Zummo, rtc-linux, stable On 14/06/12 08:30, Andrew Morton wrote: > On Thu, 14 Jun 2012 08:14:49 +0100 Lee Jones<lee.jones@linaro.org> wrote: > >> On 13/06/12 23:25, Andrew Morton wrote: >>> On Tue, 12 Jun 2012 09:57:37 +0100 >>> Lee Jones<lee.jones@linaro.org> wrote: >>> >>>> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. >>> >>> What does this mean. The kernel crashes? The registration fails? A >>> warning is emitted? >>> >>> When fixing a bug, please fully describe the consequences of that bug. >>> >>>> Cc: stable@vger.kernel.org >>> >>> Especially when suggesting a -stable backport. >> >> No problem. I'll try to remember that for next time. >> >> I see that you've taken the patch into your tree however. So do you want >> me to update the commit log and resubmit, or are you going to 'let this >> one slide'? > > Please read my emails - they're very nice! "What does this mean. The > kernel crashes? The registration fails? A warning is emitted?". You > answer that, I copy-n-paste into changelog and we're done. Ah, you're a star! Registration fails: > __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > { <snip> > if (new->flags & IRQF_ONESHOT) { <snip> > } else if (new->handler == irq_default_primary_handler) { > /* > * The interrupt was requested with handler = NULL, so > * we use the default primary handler for it. But it > * does not have the oneshot flag set. In combination > * with level interrupts this is deadly, because the > * default primary handler just wakes the thread, then > * the irq lines is reenabled, but the device still > * has the level irq asserted. Rinse and repeat.... > * > * While this works for edge type interrupts, we play > * it safe and reject unconditionally because we can't > * say for sure which type this interrupt really > * has. The type flags are unreliable as the > * underlying chip implementation can override them. > */ > pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n", irq); > ret = -EINVAL; > goto out_mask; > } <snip> -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1339428307-3850-4-git-send-email-lee.jones@linaro.org>]
* Re: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ [not found] ` <1339428307-3850-4-git-send-email-lee.jones@linaro.org> @ 2012-06-12 8:58 ` Lee Jones 0 siblings, 0 replies; 6+ messages in thread From: Lee Jones @ 2012-06-12 8:58 UTC (permalink / raw) To: Lee Jones Cc: linux-arm-kernel, linux-kernel, linus.walleij, arnd, grant.likely, Samuel Ortiz, stable Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From: Lee Jones <lee.jones@linaro.org> Date: Tue, 22 May 2012 15:13:13 +0100 Subject: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: stable@vger.kernel.org Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/ab8500-gpadc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c index b86fd8e..b6cbc3ba 100644 --- a/drivers/mfd/ab8500-gpadc.c +++ b/drivers/mfd/ab8500-gpadc.c @@ -599,7 +599,8 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev) /* Register interrupt - SwAdcComplete */ ret = request_threaded_irq(gpadc->irq, NULL, ab8500_bm_gpswadcconvend_handler, - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc", gpadc); + IRQF_ONESHOT | IRQF_NO_SUSPEND | IRQF_SHARED, + "ab8500-gpadc", gpadc); if (ret < 0) { dev_err(gpadc->dev, "Failed to register interrupt, irq: %d\n", gpadc->irq); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-14 8:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1339428307-3850-1-git-send-email-lee.jones@linaro.org>
[not found] ` <1339428307-3850-2-git-send-email-lee.jones@linaro.org>
[not found] ` <201206111531.20468.arnd@arndb.de>
2012-06-12 8:57 ` [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ Lee Jones
2012-06-13 22:25 ` Andrew Morton
2012-06-14 7:14 ` Lee Jones
2012-06-14 7:30 ` Andrew Morton
2012-06-14 8:02 ` Lee Jones
[not found] ` <1339428307-3850-4-git-send-email-lee.jones@linaro.org>
2012-06-12 8:58 ` [PATCH 03/14] mfd: ab8500-gpadc: Enable " Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).