From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <4FDFA760.5040403@intel.com>
Date: Mon, 18 Jun 2012 19:10:40 -0300
From: Eugeni Dodonov <eugeni.dodonov@intel.com>
MIME-Version: 1.0
To: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
CC: Ben Hutchings <ben@decadent.org.uk>, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [ 04/69] drm/i915: fix up ivb plane 3 pageflips
References: <20120617175941.281333656@decadent.org.uk> <20120617175941.924141588@decadent.org.uk> <20120618215555.GD3263@herton-Z68MA-D2H-B3>
In-Reply-To: <20120618215555.GD3263@herton-Z68MA-D2H-B3>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 06/18/2012 06:55 PM, Herton Ronaldo Krzesinski wrote:
>> +	default:
>> +		WARN_ONCE(1, "unknown plane in flip command\n");
>> +		ret = -ENODEV;
>> +		goto err;
> 
> Shouldn't this have been "goto err_unpin;"?
> 
> It's not a problem in the backport for 3.2, same code is in the original
> patch, just noticed it seems a problem while looking at it; but by what
> changelog says the default case is said to not trigger in "practice"
> (catch programming error), so I think it doesn't pose a real issue in
> practice.

You are right, it should be err_unpin. I sent a patch rectifying this.

In practice, this should not happen, but still, better be safe than
sorry. Thanks for catching that!

Eugeni