From: John Stultz <johnstul@us.ibm.com>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/2][RFC] Potential fix for leapsecond caused futex issue (v2)
Date: Mon, 02 Jul 2012 12:08:03 -0700 [thread overview]
Message-ID: <4FF1F193.3000707@us.ibm.com> (raw)
In-Reply-To: <20120702185103.GA32257@redhat.com>
On 07/02/2012 11:51 AM, Dave Jones wrote:
> On Sun, Jul 01, 2012 at 09:12:59PM -0700, John Stultz wrote:
> > On 07/01/2012 11:29 AM, John Stultz wrote:
> > > TODOs:
> > > * Chase down the futex/hrtimer interaction to see if this could
> > > be triggered in any other way.
> > > * Get Tglx's input/ack
> > > * Generate a backport for pre-v3.4 kernels
> > So while still waiting for feedback on the clock_was_set() change, I
> > went ahead and generated backports for most of the stable kernels on
> > kernel.org.
> >
> > Clearly these shouldn't go anywhere until the fix is upstream, but since
> > I assume there's a number of distro developers who are likely under
> > pressure to have a fix soon, I wanted to make them available so no one
> > is duplicating work.
> >
> > You can find them here:
> > http://git.linaro.org/gitweb?p=people/jstultz/linux.git;a=summary
> >
> > I did boot and test each of those kernels with my leaptest-timer.c test
> > successfully.
>
> I'm curious how the test that I did with the kernel patch,
> or Richard Cochran's userspace test program didn't trigger this bug
> when we tested last week.
It likely did trigger the issue.
> any ideas what we missed ?
In order to observe this issue, you need to notice that CLOCK_REALTIME
timers are firing one second early. The issue does not affect
CLOCK_MONOTONIC timers. Its only most visible with applications that
make sub-second CLOCK_REALTIME timeouts in a loop (most reported cases
connected with futexs). So if such an application wasn't running, it
would be easy to overlook.
thanks
-john
prev parent reply other threads:[~2012-07-02 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 18:29 [PATCH 0/2][RFC] Potential fix for leapsecond caused futex issue (v2) John Stultz
2012-07-01 18:30 ` [PATCH 1/2] [RFC] Fix clock_was_set so it is safe to call from atomic John Stultz
2012-07-02 8:53 ` Thomas Gleixner
2012-07-02 22:11 ` John Stultz
2012-07-01 18:30 ` [PATCH 2/2] [RFC] Fix leapsecond triggered hrtimer/futex load spike issue John Stultz
2012-07-01 18:34 ` [PATCH 0/2][RFC] Potential fix for leapsecond caused futex issue (v2) John Stultz
2012-07-01 18:47 ` Jan Engelhardt
2012-07-01 22:05 ` John Stultz
2012-07-02 4:12 ` John Stultz
2012-07-02 13:53 ` Prarit Bhargava
2012-07-02 18:51 ` Dave Jones
2012-07-02 19:08 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1F193.3000707@us.ibm.com \
--to=johnstul@us.ibm.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).