From: Harry Wentland <harry.wentland@amd.com>
To: Wayne Lin <Wayne.Lin@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
Date: Tue, 13 May 2025 09:35:16 -0400 [thread overview]
Message-ID: <4a3d9653-cc3f-4b24-b6a9-a2d676e8af03@amd.com> (raw)
In-Reply-To: <20250513032026.838036-1-Wayne.Lin@amd.com>
On 2025-05-12 23:20, Wayne Lin wrote:
> It's expected that we'll encounter temporary exceptions
> during aux transactions. Adjust logging from drm_info to
> drm_dbg_dp to prevent flooding with unnecessary log messages.
>
> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
> Cc: stable@vger.kernel.org
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 0d7b72c75802..25e8befbcc47 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> if (payload.write && result >= 0) {
> if (result) {
> /*one byte indicating partially written bytes*/
> - drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> result = payload.data[0];
> } else if (!payload.reply[0])
> /*I2C_ACK|AUX_ACK*/
> @@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> break;
> }
>
> - drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> }
>
> if (payload.reply[0])
> - drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> payload.reply[0]);
>
> return result;
next prev parent reply other threads:[~2025-05-13 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 3:20 [PATCH] drm/amd/display: Avoid flooding unnecessary info messages Wayne Lin
2025-05-13 12:37 ` Alex Deucher
2025-05-13 13:35 ` Harry Wentland [this message]
2025-05-13 13:49 ` Yadav, Arvind
2025-05-14 8:11 ` Christian Heusel
-- strict thread matches above, loose matches on Subject: below --
2025-05-13 3:13 Wayne Lin
2025-05-13 4:44 ` Lin, Wayne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a3d9653-cc3f-4b24-b6a9-a2d676e8af03@amd.com \
--to=harry.wentland@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox