From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:38656 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbeHVVjL (ORCPT ); Wed, 22 Aug 2018 17:39:11 -0400 Received: by mail-pl0-f66.google.com with SMTP id u11-v6so1209990plq.5 for ; Wed, 22 Aug 2018 11:13:16 -0700 (PDT) Subject: Re: [PATCH v2] bcache: release dc->writeback_lock properly in bch_writeback_thread() To: Coly Li Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, Shan Hai , stable@vger.kernel.org References: <20180822180256.15600-1-colyli@suse.de> From: Jens Axboe Message-ID: <4aead749-ba4a-d5a3-d592-bff36e38d1b5@kernel.dk> Date: Wed, 22 Aug 2018 12:13:12 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 8/22/18 12:07 PM, Coly Li wrote: > On 2018/8/23 2:02 AM, Coly Li wrote: >> From: Shan Hai >> >> The writeback thread would exit with a lock held when the cache device is >> detached via sysfs interface, fix it by releasing the held lock before exiting >> the while-loop. >> >> Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set) >> Signed-off-by: Shan Hai >> Signed-off-by: Coly Li >> Tested-by: Shenghui Wang >> Cc: stable@vger.kernel.org #4.17+ >> --- >> Changelog: >> v2: add Fixes tag by Coly Li. >> v1: initial patch from Shan Hai. > > Hi Jens, > > Please pick this patch for your next pull request. The change from Shan > Hai fixes a real issue which is reported and lately verified by Shenghui > Wang. Applied - but I fixed up the commit message. Please keep lines at 72 characters for git commits. -- Jens Axboe