From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] r8169: fix LED-related deadlock on module removal
Date: Wed, 17 Apr 2024 08:02:31 +0200 [thread overview]
Message-ID: <4b0495fd-fab5-4341-9b06-2f48613ee921@gmail.com> (raw)
In-Reply-To: <20240416193458.1e2c799d@kernel.org>
On 17.04.2024 04:34, Jakub Kicinski wrote:
> On Mon, 15 Apr 2024 13:57:17 +0200 Heiner Kallweit wrote:
>> Binding devm_led_classdev_register() to the netdev is problematic
>> because on module removal we get a RTNL-related deadlock. Fix this
>> by avoiding the device-managed LED functions.
>>
>> Note: We can safely call led_classdev_unregister() for a LED even
>> if registering it failed, because led_classdev_unregister() detects
>> this and is a no-op in this case.
>>
>> Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
>> Cc: <stable@vger.kernel.org> # 6.8.x
>> Reported-by: Lukas Wunner <lukas@wunner.de>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Looks like I already applied one chunk of this as commit 97e176fcbbf3
> ("r8169: add missing conditional compiling for call to r8169_remove_leds")
> Is it worth throwing that in as a Fixes tag?
This is a version of the fix modified to apply on 6.8.
It's not supposed to be applied on net / net-next.
Should I have sent it to stable@vger.kernel.org only?
next prev parent reply other threads:[~2024-04-17 6:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 11:57 [PATCH net] r8169: fix LED-related deadlock on module removal Heiner Kallweit
2024-04-17 2:34 ` Jakub Kicinski
2024-04-17 6:02 ` Heiner Kallweit [this message]
2024-04-17 7:04 ` Greg KH
2024-04-17 7:16 ` Heiner Kallweit
2024-04-17 7:43 ` Greg KH
2024-04-17 22:33 ` Lukas Wunner
2024-04-18 9:55 ` Greg KH
2024-04-18 14:33 ` Heiner Kallweit
2024-04-18 14:44 ` Greg KH
2024-04-17 13:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b0495fd-fab5-4341-9b06-2f48613ee921@gmail.com \
--to=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox