From: Hans de Goede <hdegoede@redhat.com>
To: tom.ty89@gmail.com, gregkh@linuxfoundation.org
Cc: kraxel@redhat.com, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] uas: remove can_queue set in host template
Date: Tue, 24 May 2016 08:58:30 +0200 [thread overview]
Message-ID: <4b23f12a-eb80-8196-a266-c209cdb5f387@redhat.com> (raw)
In-Reply-To: <574359f3.4667620a.6c0f.528f@mx.google.com>
Hi,
On 23-05-16 21:28, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made
> qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant.
> Removing it to avoid confusion.
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
I agree removing this is good:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 4d49fce..e03c490 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -848,7 +848,6 @@ static struct scsi_host_template uas_host_template = {
> .slave_configure = uas_slave_configure,
> .eh_abort_handler = uas_eh_abort_handler,
> .eh_bus_reset_handler = uas_eh_bus_reset_handler,
> - .can_queue = MAX_CMNDS,
> .this_id = -1,
> .sg_tablesize = SG_NONE,
> .skip_settle_delay = 1,
>
prev parent reply other threads:[~2016-05-24 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 19:28 [PATCH v2 1/1] uas: remove can_queue set in host template tom.ty89
2016-05-24 6:58 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b23f12a-eb80-8196-a266-c209cdb5f387@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kraxel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox