Re: [PATCH 6.5.y] platform/x86: Add s2idle quirk for more Lenovo laptops

[Mario Limonciello <mario.limonciello@amd.com>]

On 10/31/2023 06:10, David Lazar wrote:
> On Mon, 30 Oct 2023 16:30, Mario Limonciello wrote:
>> In this case are there modifications or is a clean cherry-pick?  If it's not
>> a clean cherry pick, why?
> 
> This wasn't a clean cherry pick because the code has been moved
> from  drivers/platform/x86/amd/pmc-quirks.c      in 6.5.y
> to    drivers/platform/x86/amd/pmc/pmc-quirks.c  in 6.6.y.
> 
> 
>> If it's just missing another system in the quirk list it's cleaner to
>> backport that missing system and then have a clean pick.
> 
> In this case (the 6.5 patch) there was no missing system in the quirks
> list.  However, in the 6.1 version, the HP system *is* missing from
> the list (it looks like the patch that added that system wasn't
> backported to 6.1).  But even adding that system wouldn't result in a
> clean cherry pick, given that the code had been moved once before
> from  drivers/platform/x86/thinkpad_acpi.c   in 6.1.y
> to    drivers/platform/x86/amd/pmc-quirks.c  in 6.5.y.
> 
> I had refrained from adding the missing system also in order to stay
> close to the upstream patch.
> 
> In any case, I see Sasha and Greg are already working on these patches,
> so I'll leave them alone for now, to not generate more work for them.
> 
> Thanks for your help, everyone, and please let me know if there's
> anything else I should do.
> 
> -=[david]=-

Got it, thanks I think you made the right decisions in both 6.1 and 6.5 
versions.