From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f68.google.com ([209.85.208.68]:38734 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727507AbeJ1XxP (ORCPT ); Sun, 28 Oct 2018 19:53:15 -0400 Received: by mail-ed1-f68.google.com with SMTP id c1-v6so5142061ede.5 for ; Sun, 28 Oct 2018 08:08:22 -0700 (PDT) Subject: Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD To: Diego Viola Cc: axboe@kernel.dk, tj@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20181028143403.2285-1-diego.viola@gmail.com> From: Hans de Goede Message-ID: <4e3db790-606c-24aa-b612-b88bf528dbdf@redhat.com> Date: Sun, 28 Oct 2018 16:08:20 +0100 MIME-Version: 1.0 In-Reply-To: <20181028143403.2285-1-diego.viola@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hi, On 28-10-18 15:34, Diego Viola wrote: > med_power_with_dipm still causes freezes after updating the firmware to > the latest version (DXT04L5Q). > > Set model_rev to NULL and blacklist the device. > > Signed-off-by: Diego Viola Thank you for the patch. Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/ata/libata-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 6e594644cb1d..a7f5202a4815 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -4553,7 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { > /* These specific Samsung models/firmware-revs do not handle LPM well */ > { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, }, > { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, }, > - { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, }, > + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, }, > > /* devices that don't properly handle queued TRIM commands */ > { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM | >