From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA2E2147F9; Tue, 22 Apr 2025 14:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745331525; cv=none; b=U9LUSLrE3lEnztIS34geSU+e0Iq2MzT2nRhIg0INzv6HDHcMkHntofrYLBk+Pnbm5jmDYNoEnqphxEBqP+s9FoaXkcxO2UBWz24j8R4h/oPm0SeVWpW7ogxi05ua8NKWwUrJNMEEy5EgPiIBMBIczY2WAzm7EbT61f5Ji5J3T/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745331525; c=relaxed/simple; bh=7og7s6hoXNGAFJwwFuz4N620MswjEFEpEFE01/gyPhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XkcT25jqV7B1H69sDlyyBLDWWntbyQIUma7HPTDJvFSao+vZgwaTK9bpuSfinzmF/rlzT9sqd+7zUshQ6sM7640drrbGozFxlXWHEP53JvAP9zQnJMZqiC4CA9tCbBVAGzZxs3v35V1o7f5VzteQ1GywU7LB3jvqJOXf64P7J5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PsLyfEyJ; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PsLyfEyJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745331523; x=1776867523; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7og7s6hoXNGAFJwwFuz4N620MswjEFEpEFE01/gyPhc=; b=PsLyfEyJulOWN6ixc92QNtXUYu/7N1PVsmOgjFr1odepTtNZuVlCQRv5 p+tGntCO4rAMw5DeC+LcPMoOP001qwYnttI/R4WSms054wwD1nUOU0RNL Vqmc2tNA3IFxhWva/OaN6vNxABglXQPSVu1m3uoNaVvFVTDEJzD3Yh/DJ Uo9hEA4sYuLQDs1aRVk/ySbOd72g/wUYaQwTJ/F6Jw1R4dF4kRfM1A+mU qknC1M/NXPOIHNAahCigSDNtczlhzcxl6F2DInMKjTXWfmjm+Yk8Rk1xC bnjiWkFm9/KgtFzg0s++R2H1DNyIZp18noWQAvaVafowd+TrwFkb54hvz Q==; X-CSE-ConnectionGUID: ny//4h1qSjCi3DgV7K6Q+Q== X-CSE-MsgGUID: 2v8+SZE/Sm6be+lWG2Tv0A== X-IronPort-AV: E=McAfee;i="6700,10204,11411"; a="58258269" X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="58258269" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 07:18:43 -0700 X-CSE-ConnectionGUID: g/BlTnMSRIiDqmbvuowq9w== X-CSE-MsgGUID: lf9Bf2fyR8ab6GilzS6szQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="136886954" Received: from johunt-mobl9.ger.corp.intel.com (HELO [10.124.220.191]) ([10.124.220.191]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 07:18:42 -0700 Message-ID: <4ea35cc4-1720-494c-9d90-e4669c8cde08@intel.com> Date: Tue, 22 Apr 2025 07:18:41 -0700 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Handle Ice Lake MONITOR erratum To: Ingo Molnar , Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, andrew.cooper3@citrix.com, Len Brown , Peter Zijlstra , "Rafael J. Wysocki" , Srinivas Pandruvada , stable@vger.kernel.org References: <20250421192205.7CC1A7D9@davehans-spike.ostc.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/21/25 23:46, Ingo Molnar wrote: >> /* >> + * These CPUs have buggy MWAIT/MONITOR implementations that >> + * usually manifest as hangs or stalls at boot. >> + */ >> +#define MWAIT_VFM(_vfm) \ >> + X86_MATCH_VFM_FEATURE(_vfm, X86_FEATURE_MWAIT, 0) >> +static const struct x86_cpu_id monitor_bug_list[] = { >> + MWAIT_VFM(INTEL_ATOM_GOLDMONT), >> + MWAIT_VFM(INTEL_LUNARLAKE_M), >> + MWAIT_VFM(INTEL_ICELAKE_X), /* Erratum ICX143 */ >> + {}, >> +}; > While it's just an internal helper, macro names should still be > intuitive: > > s/MWAIT_VFM > /VFM_MWAIT_BUG The current convention is to end with the thing that's being matched, like "_FEATURE" or "_VFM" in the X86_MATCH*() macros. That's why I ordered it the way I did. As for including "BUG", the _macro_ doesn't match CPUs with the bug. It's just matching CPUs with the specified VFM that have MWAIT. It could (theoretically) get used for non-bug things so I don't think it's intuitive to put "BUG" in the name. But, honestly, we have a tone of these one-off x86_cpu_id macros around. They have lots of pretty silly naming, but they're mostly only used at one isolated site so I don't worry about the naming _too_ much.