From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Melody Olvera <quic_molvera@quicinc.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rajendra Nayak <quic_rjendra@quicinc.com>,
manivannan.sadhasivam@oss.qualcomm.com, stable@vger.kernel.org
Subject: Re: [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable()
Date: Fri, 2 Jan 2026 12:39:55 +0100 [thread overview]
Message-ID: <500313f1-51fd-450e-877e-e4626b7652bc@oss.qualcomm.com> (raw)
In-Reply-To: <edca97aa-429e-4a6b-95a0-2a6dfe510ef2@oss.qualcomm.com>
On 1/2/26 12:36 PM, Krishna Chaitanya Chundru wrote:
>
>
> On 1/2/2026 5:04 PM, Konrad Dybcio wrote:
>> On 1/2/26 10:43 AM, Krishna Chaitanya Chundru wrote:
>>> With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This
>>> can happen during scenarios such as system suspend and breaks the resume
>>> of PCIe controllers from suspend.
>> Isn't turning the GDSCs off what we want though? At least during system
>> suspend?
> If we are keeping link in D3cold it makes sense, but currently we are not keeping in D3cold
> so we don't expect them to get off.
Since we seem to be tackling that in parallel, it seems to make sense
that adding a mechanism to let the PCIe driver select "on" vs "ret" vs
"off" could be useful for us
FWIW I recall I could turn off the GDSCs on at least makena with the old
suspend patches and the controllers would come back to life afterwards
Konrad
next prev parent reply other threads:[~2026-01-02 11:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 9:43 [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable() Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 1/7] clk: qcom: gcc-sc7280: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 2/7] clk: qcom: gcc-sa8775p: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 3/7] clk: qcom: gcc-sm8750: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 4/7] clk: qcom: gcc-glymur: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 5/7] clk: qcom: gcc-qcs8300: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 6/7] clk: qcom: gcc-x1e80100: " Krishna Chaitanya Chundru
2026-01-02 9:49 ` Bryan O'Donoghue
2026-01-02 9:43 ` [PATCH 7/7] clk: qcom: gcc-kaanapali: " Krishna Chaitanya Chundru
2026-01-02 11:34 ` [PATCH 0/7] clk: qcom: gcc: " Konrad Dybcio
2026-01-02 11:36 ` Krishna Chaitanya Chundru
2026-01-02 11:39 ` Konrad Dybcio [this message]
2026-01-02 13:19 ` Krishna Chaitanya Chundru
2026-01-02 13:57 ` Konrad Dybcio
2026-01-02 16:12 ` Bryan O'Donoghue
2026-01-05 4:54 ` Krishna Chaitanya Chundru
2026-01-05 5:14 ` Manivannan Sadhasivam
2026-01-05 9:47 ` Stephan Gerhold
2026-01-08 5:58 ` Manivannan Sadhasivam
2026-01-09 15:49 ` Bjorn Andersson
2026-01-09 17:33 ` Stephan Gerhold
2026-01-09 18:48 ` Bjorn Andersson
2026-01-05 5:15 ` Manivannan Sadhasivam
2026-01-30 10:36 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500313f1-51fd-450e-877e-e4626b7652bc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=mturquette@baylibre.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox