[PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Alexey Charkov]

Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.

Different board versions use different incompatible WiFi/Bluetooth modules
so split the version-specific bits out into an overlay. Basic WiFi
functionality works even without an overlay, but OOB interrupts and
all Bluetooth stuff requires one.

My board is v1.2, so the overlay is only provided for it.

Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
Changes in v2:
- Expand the commit message for the patch linking CPU regulators and add
  tags for stable (thanks Nicolas)
- Fix the ordering of cpu_b* nodes vs. combphy0_ps (thanks Diederik)
- Drop the USB patch, as Nicolas has already posted a more comprehensive
  series including also the Type-C stuff (thanks Nicolas)
- Pick up Nicolas' tags
- Split out board version specific WiFi/Bluetooth stuff into an overlay
- Link to v1: https://lore.kernel.org/r/20250603-sige5-updates-v1-0-717e8ce4ab77@gmail.com

---
Alexey Charkov (4):
      arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
      arm64: dts: rockchip: add SDIO controller on RK3576
      arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
      arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2

 arch/arm64/boot/dts/rockchip/Makefile              |  5 ++
 .../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso  | 49 +++++++++++++
 .../boot/dts/rockchip/rk3576-armsom-sige5.dts      | 85 ++++++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3576.dtsi           | 16 ++++
 4 files changed, 155 insertions(+)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250602-sige5-updates-a162b501a1b1

Best regards,
-- 
Alexey Charkov <alchark@gmail.com>

[PATCH v2 1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5

[Alexey Charkov]

List both CPU supply regulators which drive the little and big CPU
clusters, respectively, so that cpufreq can pick them up.

Without this patch the cpufreq governor attempts to raise the big CPU
frequency under high load, while its supply voltage stays at 850000 uV.
This causes system instability and, in my case, random reboots.

With this patch, supply voltages are adjusted in step with frequency
changes from 700000-737000 uV in idle to 950000 uV under full load,
and the system appears to be stable.

While at this, list all CPU supplies for completeness.

Cc: stable@vger.kernel.org
Fixes: 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board")
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
 .../boot/dts/rockchip/rk3576-armsom-sige5.dts      | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index b09e789c75c47fec7cf7e9810ab0dcca32d9404a..801b40fea4e8808c3f889ddd3ed3aa875a377567 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -211,10 +211,38 @@ &combphy0_ps {
 	status = "okay";
 };
 
+&cpu_b0 {
+	cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b1 {
+	cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b2 {
+	cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b3 {
+	cpu-supply = <&vdd_cpu_big_s0>;
+};
+
 &cpu_l0 {
 	cpu-supply = <&vdd_cpu_lit_s0>;
 };
 
+&cpu_l1 {
+	cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l2 {
+	cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l3 {
+	cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
 &gmac0 {
 	phy-mode = "rgmii-id";
 	clock_in_out = "output";

-- 
2.49.0

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Rob Herring (Arm)]

On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> 
> Different board versions use different incompatible WiFi/Bluetooth modules
> so split the version-specific bits out into an overlay. Basic WiFi
> functionality works even without an overlay, but OOB interrupts and
> all Bluetooth stuff requires one.
> 
> My board is v1.2, so the overlay is only provided for it.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Changes in v2:
> - Expand the commit message for the patch linking CPU regulators and add
>   tags for stable (thanks Nicolas)
> - Fix the ordering of cpu_b* nodes vs. combphy0_ps (thanks Diederik)
> - Drop the USB patch, as Nicolas has already posted a more comprehensive
>   series including also the Type-C stuff (thanks Nicolas)
> - Pick up Nicolas' tags
> - Split out board version specific WiFi/Bluetooth stuff into an overlay
> - Link to v1: https://lore.kernel.org/r/20250603-sige5-updates-v1-0-717e8ce4ab77@gmail.com
> 
> ---
> Alexey Charkov (4):
>       arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
>       arm64: dts: rockchip: add SDIO controller on RK3576
>       arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
>       arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> 
>  arch/arm64/boot/dts/rockchip/Makefile              |  5 ++
>  .../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso  | 49 +++++++++++++
>  .../boot/dts/rockchip/rk3576-armsom-sige5.dts      | 85 ++++++++++++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi           | 16 ++++
>  4 files changed, 155 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250602-sige5-updates-a162b501a1b1
> 
> Best regards,
> --
> Alexey Charkov <alchark@gmail.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250614-sige5-updates-v2-0-3bb31b02623c@gmail.com:

arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm0:pwm0m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch0:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch4:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch6:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1_sda:i3c1_sdam1-pu:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm1:pwm1m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:0:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:1:2: 14 is greater than the maximum of 13
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Alexey Charkov]

On Tue, Jun 17, 2025 at 1:46 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> >
> > Different board versions use different incompatible WiFi/Bluetooth modules
> > so split the version-specific bits out into an overlay. Basic WiFi
> > functionality works even without an overlay, but OOB interrupts and
> > all Bluetooth stuff requires one.
> >
> > My board is v1.2, so the overlay is only provided for it.
> >
> > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > ---
> > Changes in v2:
> > - Expand the commit message for the patch linking CPU regulators and add
> >   tags for stable (thanks Nicolas)
> > - Fix the ordering of cpu_b* nodes vs. combphy0_ps (thanks Diederik)
> > - Drop the USB patch, as Nicolas has already posted a more comprehensive
> >   series including also the Type-C stuff (thanks Nicolas)
> > - Pick up Nicolas' tags
> > - Split out board version specific WiFi/Bluetooth stuff into an overlay
> > - Link to v1: https://lore.kernel.org/r/20250603-sige5-updates-v1-0-717e8ce4ab77@gmail.com
> >
> > ---
> > Alexey Charkov (4):
> >       arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> >       arm64: dts: rockchip: add SDIO controller on RK3576
> >       arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> >       arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> >
> >  arch/arm64/boot/dts/rockchip/Makefile              |  5 ++
> >  .../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso  | 49 +++++++++++++
> >  .../boot/dts/rockchip/rk3576-armsom-sige5.dts      | 85 ++++++++++++++++++++++
> >  arch/arm64/boot/dts/rockchip/rk3576.dtsi           | 16 ++++
> >  4 files changed, 155 insertions(+)
> > ---
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > change-id: 20250602-sige5-updates-a162b501a1b1
> >
> > Best regards,
> > --
> > Alexey Charkov <alchark@gmail.com>
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
>  Base: using specified base-commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250614-sige5-updates-v2-0-3bb31b02623c@gmail.com:
>
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm0:pwm0m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch0:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch4:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch6:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1_sda:i3c1_sdam1-pu:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm1:pwm1m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:0:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:1:2: 14 is greater than the maximum of 13
>         from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#

N.B.: these are unrelated to my series, and fixed by Nicolas' patch at
[1], already in -next.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86491c2b99e5adbb56d76286d6668effb36d3c90

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Heiko Stuebner]

On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> 
> Different board versions use different incompatible WiFi/Bluetooth modules
> so split the version-specific bits out into an overlay. Basic WiFi
> functionality works even without an overlay, but OOB interrupts and
> all Bluetooth stuff requires one.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
      commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
[2/4] arm64: dts: rockchip: add SDIO controller on RK3576
      commit: e490f854b46369b096f3d09c0c6a00f340425136
[3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
      commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
[4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
      commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63

Patch 1 as fix for v6.16

I've also fixed the wifi@1 node in the overlay - which was using
spaces instead of tabs.

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Alexey Charkov]

On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
>
> On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> >
> > Different board versions use different incompatible WiFi/Bluetooth modules
> > so split the version-specific bits out into an overlay. Basic WiFi
> > functionality works even without an overlay, but OOB interrupts and
> > all Bluetooth stuff requires one.
> >
> > [...]
>
> Applied, thanks!
>
> [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
>       commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
>       commit: e490f854b46369b096f3d09c0c6a00f340425136
> [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
>       commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
>       commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
>
> Patch 1 as fix for v6.16
>
> I've also fixed the wifi@1 node in the overlay - which was using
> spaces instead of tabs.

Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
from binding examples is not a universally good idea :)

By the way, is there any tool that helps catch those?

Best regards,
Alexey

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Heiko Stuebner]

Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> >
> > On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> > >
> > > Different board versions use different incompatible WiFi/Bluetooth modules
> > > so split the version-specific bits out into an overlay. Basic WiFi
> > > functionality works even without an overlay, but OOB interrupts and
> > > all Bluetooth stuff requires one.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> >       commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> > [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
> >       commit: e490f854b46369b096f3d09c0c6a00f340425136
> > [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> >       commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> > [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> >       commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
> >
> > Patch 1 as fix for v6.16
> >
> > I've also fixed the wifi@1 node in the overlay - which was using
> > spaces instead of tabs.
> 
> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
> from binding examples is not a universally good idea :)
> 
> By the way, is there any tool that helps catch those?

checkpatch.pl would be the tool to do that, but I'm not sure it handles
this at this time.

I also only saw things when I looked at the patch in "mcedit", because
it nicely distinguishes between tabs and spaces :-) .

Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

On Fri Jun 20, 2025 at 10:44 AM CEST, Heiko Stuebner wrote:
> Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
>> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
>> >
>> > I've also fixed the wifi@1 node in the overlay - which was using
>> > spaces instead of tabs.
>> 
>> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
>> from binding examples is not a universally good idea :)
>> 
>> By the way, is there any tool that helps catch those?
>
> checkpatch.pl would be the tool to do that, but I'm not sure it handles
> this at this time.
>
> I also only saw things when I looked at the patch in "mcedit", because
> it nicely distinguishes between tabs and spaces :-) .

In vim, ``:set list`` makes them visible as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]