From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <509EBBDE.9020902@suse.cz>
Date: Sat, 10 Nov 2012 21:41:02 +0100
From: Jiri Slaby <jslaby@suse.cz>
MIME-Version: 1.0
To: Johan Hovold <jhovold@gmail.com>
CC: Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net,
	Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH] USB: mos7840: remove unused variable
References: <CAMgPeKUTpA+qn3TA+4xpRa4z_Y1E+6mk+_Xdom+ugdqCttL3aQ@mail.gmail.com>
In-Reply-To: <CAMgPeKUTpA+qn3TA+4xpRa4z_Y1E+6mk+_Xdom+ugdqCttL3aQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 11/08/2012 06:28 PM, Johan Hovold wrote:
> Fix warning about unused variable introduced by commit e681b66f2e19fa
> ("USB: mos7840: remove invalid disconnect handling") upstream.
> 
> A subsequent fix which removed the disconnect function got rid of the
> warning but that one was only backported to v3.6.
> 
> Reported-by: Jiri Slaby <jslaby@suse.cz>

FWIW Looks good to me.

> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
> 
> This patch against v3.4 also applies to v3.0 (and v3.2).
> 
> Thanks,
> Johan
> 
>  drivers/usb/serial/mos7840.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 0179d34..c854235 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2581,7 +2581,6 @@ error:
>  static void mos7840_disconnect(struct usb_serial *serial)
>  {
>  	int i;
> -	unsigned long flags;
>  	struct moschip_port *mos7840_port;
>  	dbg("%s", " disconnect :entering..........");
> 

thanks,
-- 
js
suse labs