From: "H. Peter Anvin" <hpa@zytor.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Tim Gardner <rtg.canonical@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Olof Johansson <olof@lixom.net>, Tony Luck <tony.luck@intel.com>,
Steve Langasek <steve.langasek@canonical.com>,
Colin Ian King <colin.king@canonical.com>,
Matt Fleming <matt.fleming@intel.com>,
David Airlie <airlied@linux.ie>,
Corentin Chary <corentincj@iksaif.net>,
Dave Jiang <dave.jiang@intel.com>,
Peter Jones <pjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] efi: Make 'efi_enabled' a function to query EFI facilities
Date: Mon, 21 Jan 2013 14:42:03 -0600 [thread overview]
Message-ID: <50FDA81B.9090602@zytor.com> (raw)
In-Reply-To: <1358800838-10459-2-git-send-email-matt@console-pimps.org>
On 01/21/2013 02:40 PM, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> Originally 'efi_enabled' indicated whether a kernel was booted from
> EFI firmware. Over time its semantics have changed, and it now
> indicates whether or not we are booted on an EFI machine with
> bit-native firmware, e.g. 64-bit kernel with 64-bit firmware.
>
> But users actually want to query 'efi_enabled' for different reasons -
> what they really want access to is the list of available EFI
> facilities.
>
> For instance, the x86 reboot code needs to know whether it can invoke
> the ResetSystem() function provided by the EFI runtime services, while
> the ACPI OSL code wants to know whether the EFI config tables were
> mapped successfully. There are also checks in some of the platform
> driver code to simply see if they're running on an EFI machine (which
> would make it a bad idea to do BIOS-y things).
>
Could you please explain as part of the checkin comment why this is
needed for urgent/stable? I.e. what breaks *now*, as opposed to this
being a cleanup for the next merge window.
-hpa
next prev parent reply other threads:[~2013-01-21 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1358800838-10459-1-git-send-email-matt@console-pimps.org>
2013-01-21 20:40 ` [PATCH 1/2] efi: Make 'efi_enabled' a function to query EFI facilities Matt Fleming
2013-01-21 20:42 ` H. Peter Anvin [this message]
2013-01-21 21:12 ` Matt Fleming
2013-01-23 4:16 ` Ben Hutchings
2013-01-23 7:52 ` Matt Fleming
2013-01-23 13:17 ` Ben Hutchings
2013-01-25 23:53 ` Matt Fleming
2013-01-21 20:54 ` Dave Jiang
2013-01-21 20:56 ` Matthew Garrett
2013-01-30 18:35 ` [tip:x86/urgent] " tip-bot for Matt Fleming
2013-01-21 20:40 ` [PATCH 2/2] samsung-laptop: Disable on EFI hardware Matt Fleming
2013-01-30 18:36 ` [tip:x86/urgent] " tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FDA81B.9090602@zytor.com \
--to=hpa@zytor.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=corentincj@iksaif.net \
--cc=dave.jiang@intel.com \
--cc=konrad@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=olof@lixom.net \
--cc=pjones@redhat.com \
--cc=rjw@sisk.pl \
--cc=rtg.canonical@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steve.langasek@canonical.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox