From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5122BC8A.6040503@suse.cz> Date: Tue, 19 Feb 2013 00:43:06 +0100 From: Jiri Slaby MIME-Version: 1.0 To: Marcin Slusarz CC: bskeggs@redhat.com, dri-devel@lists.freedesktop.org, LKML , stable Subject: Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242 References: <5122021F.1060207@suse.cz> <20130218232335.GA9730@joi.lan> In-Reply-To: <20130218232335.GA9730@joi.lan> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: >> Hi, >> >> we have a report of WARNING from 3.7.6 in nouveau at >> drivers/gpu/drm/nouveau/core/core/mm.c:242 here: >> https://bugzilla.novell.com/show_bug.cgi?id=802347#c11 >> >> There is an order 4 allocation failure in nouveau_drm_open -> >> nouveau_vm_create, i.e. this one failed: >> vm->pgt = kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL); >> >> Then, on the error path in still in nouveau_drm_open, it is followed by >> a call to nouveau_cli_destroy. But that one calls nouveau_vm_ref -> >> nouveau_mm_fini -> nouveau_vm_del -> nouveau_mm_fini which triggers the >> warning. >> >> Any ideas? > > Crash/warning should be fixed by commit cfd376b6bfccf33782a0748a9c70f7f752f8b869 > "drm/nouveau/vm: fix memory corruption when pgt allocation fails". Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there... Isn't this a stable-3.7 candidate? > Tomorrow I'll post a patch for page allocation failure. What do you mean -- what kind of patch? -- js suse labs