From: Ryan Mallon <rmallon@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
stable@vger.kernel.org, FlorianSchandinat@gmx.de,
damien.cassou@lifl.fr
Subject: Re: [PATCH] video: ep93xx_fb: include <linux/io.h> for devm_ioremap()
Date: Sat, 16 Mar 2013 09:30:17 +1100 [thread overview]
Message-ID: <5143A0F9.1010301@gmail.com> (raw)
In-Reply-To: <201303151520.26873.hartleys@visionengravers.com>
On 16/03/13 09:20, H Hartley Sweeten wrote:
> commit be867814 "drivers/video/ep93xx-fb.c: use devm_ functions"
>
> Introduced a build error:
>
> drivers/video/ep93xx-fb.c: In function 'ep93xxfb_probe':
> drivers/video/ep93xx-fb.c:532: error: implicit declaration of function 'devm_ioremap'
> drivers/video/ep93xx-fb.c:533: warning: assignment makes pointer from integer without a cast
>
> Include <linux/io.h> to pickup the declaration of 'devm_ioremap'.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: <stable@vger.kernel.org>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Damien Cassou <damien.cassou@lifl.fr>
Acked-by: Ryan Mallon <rmallon@gmail.com>
> ---
> drivers/video/ep93xx-fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c
> index 3f2519d..e06cd5d 100644
> --- a/drivers/video/ep93xx-fb.c
> +++ b/drivers/video/ep93xx-fb.c
> @@ -23,6 +23,7 @@
> #include <linux/slab.h>
> #include <linux/clk.h>
> #include <linux/fb.h>
> +#include <linux/io.h>
>
> #include <linux/platform_data/video-ep93xx.h>
>
prev parent reply other threads:[~2013-03-15 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 22:20 [PATCH] video: ep93xx_fb: include <linux/io.h> for devm_ioremap() H Hartley Sweeten
2013-03-15 22:30 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5143A0F9.1010301@gmail.com \
--to=rmallon@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=damien.cassou@lifl.fr \
--cc=hartleys@visionengravers.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).